Javascript static var

Question

Besides readability, is there any reason to avoid or not program static variables using this style?

function not_global()
{
    var print;

    (function() {
        var static = value;
        print = function(value) {
            static = value;
        }
    })();
}

that's global, which means you're polluting the global namespace. — zzzzBov
– zzzzBov, Commented Jan 31, 2014 at 0:17
Given that you're declaring the variable in the global namespace, this just seems unnecessarily convoluted. — user1864610
– user1864610, Commented Jan 31, 2014 at 0:17
function foo(){}; foo.bar = function(){}; bar here would be a "static" property/variable as it is only accessible by foo.bar — Patrick Evans
– Patrick Evans, Commented Jan 31, 2014 at 0:19
It's not static - but a normal variable, or a free variable from the IIFE perspective — zerkms
– zerkms, Commented Jan 31, 2014 at 0:20

Andrew Clark · Accepted Answer · 2014-01-31 00:18:49Z

1

I would avoid that style. It isn't very explicit so it becomes difficult without comments to tell that print being exposed outside of the IIFE is intentional. Instead, I would suggest returning print from the function and assigning it there:

var print = (function()
{
    var text_log=document.getElementById('text_log_text');

    return function(string)
    {
        text_log.innerHTML+='<br />'+string;
    };
})();

Note that polluting the global namespace is discouraged, so really the best answer here is to just not have print exposed outside. This answer assumes you have already thought through that, and either your IIFE is actually nested in another function (so it isn't polluting the global namespace), or you really do want print to be global.

answered Jan 31, 2014 at 0:18

Andrew Clark

210k36 gold badges285 silver badges310 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript static var

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related