PHP submit button in echo that can do a little javascripting

Question

I currently have a script that outputs certain values in a db and it's working as intended. But now, I am trying to add a column with buttons. Very every row that the db spits out, I need a button that would open run a javascript function and then open a window. This works in HTML just fine, but because its in PHP and in #echo its not working. It has to do something with my quotes, but I can't seem to figure it out. Does someone know how to have a button embedded in an echo that can also do javascript? FYI - I would like the buttons to be within the echo so if there are 10 rows, 10 buttons will show up. Thanks!

while($row = odbc_fetch_array($rs)) 
{

echo '
    <tr>
    <td class="td" valign="top">
    <input type="submit" name="SendEmailManually" value="Submit" onclick="window.open("index.php","newWin", "width=400,height=400")" /></td>
    <td class="td" valign="top">' . $Value1 . '</td>
    <td class="td" valign="top">' . $Value2 . '</td>
            <td class="td" valign="top">' . $Value3 . '</td>
            <td class="td" valign="top">' . $Value4 . '</td>
    </tr> 
';
}

Your onclick attribute can't have double quotes within double quotes. — SSH This
– SSH This, Commented Jan 29, 2014 at 22:19
@SSHThis - the table currently goes like this - |button|$Value1|$Value2|$Value3|$Value4 - The button shows but does nothing when I click it. — Yusof
– Yusof, Commented Jan 29, 2014 at 22:22
@RUJordan - I did have a function but it still did not work. I then tried the inline javascript in hoping that would work. — Yusof
– Yusof, Commented Jan 29, 2014 at 22:23

Sterling Archer · Accepted Answer · 2014-01-29 22:24:15Z

1

Please don't use inline javascript, it's ugly and even worse so when you need to escape quotes to make it work.

function openIndex() {
    window.open("index.php","newWin", "width=400,height=400");
}

throw your window code into a function, and assign the input an id (remove the onclick attribute).

Or, if no id is to be assigned, use querySelector().

var x = document.querySelector("[name='SendEmailManually']");
x.addEventListener("click",openIndex,false);

Add your event listener, and suddenly you have some good looking code that works nicely with delegated events.

answered Jan 29, 2014 at 22:24

Sterling Archer

22.5k19 gold badges86 silver badges121 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user3141031 · Accepted Answer · 2014-01-29 22:20:32Z

0

You are using double quotes, which interfere with the double quotes encasing the value of the onclick attribute. Use single quotes instead. "window.open('index.php','newWin', 'width=400,height=400')"

answered Jan 29, 2014 at 22:20

user3141031

Collectives™ on Stack Overflow

PHP submit button in echo that can do a little javascripting

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related