scanf check in while loop to restrict integer input

Question

I am writing a code asking the user to input 10 integers, which are then fed to him backwards. I would like to create a "scanf check" to restrict character input. The while loop works insofar that it doesn't accept char, but it skips a integer input.

int main()
{

    int i = 0, number[10] = {0};
    char buf[128] = {0};

    for (i = 0; i < 10; i++)
    {
      printf("Please input number %d : ", i+1);

         while(scanf("%d", &number[i]) != 1)
      {
         scanf("%s", &buf);
         printf("Sorry, [%s] is not a number. Please input number %d : ", &buf, i);
      }
    }

    for (i = 0; i < 10; i++)
    {
    printf("\n Number %d is %d", (10-i), number[9-i]);
    }

    return EXIT_SUCCESS;
}

@SakthiKumar: No, never use fflush(stdin) - it results in UB on many platforms. — Paul R
– Paul R, Commented Jan 28, 2014 at 9:14
@SakthiKumar, thanks for your input. Paul R, what would you recommmend? — MIIJ
– MIIJ, Commented Jan 28, 2014 at 9:15
You can use fpurge if your platform has it, or for maximum portability just read characters and discard until you hit a newline. — Paul R
– Paul R, Commented Jan 28, 2014 at 9:17
Oops! fflush is only for output streams. Sorry for the comment. — Sakthi Kumar
– Sakthi Kumar, Commented Jan 28, 2014 at 9:20

David Ranieri · Accepted Answer · 2014-01-28 13:13:57Z

4

As pointed out by H2CO3, don't use scanf, an alternative is fgets and strtol:

int i, number[10] = {0};
char buf[128], *p;

for (i = 0; i < 10; i++) {
    printf("Please input number %d : ", i+1);
    while (1) {
        fgets(buf, sizeof(buf), stdin);
        if ((p = strchr(buf, '\n')) != NULL) {
            *p = '\0';
        }
        number[i] = (int)strtol(buf, &p, 10);
        if (p == buf || *p != '\0')  {
            printf("Sorry, [%s] is not a number. Please input number %d : ", buf, i + 1);
        } else {
            break;
        }  
    }
}
for (i = 0; i < 10; i++) {
    printf("\n Number %d is %d", (10-i), number[9-i]);
}
return EXIT_SUCCESS;

edited Jan 28, 2014 at 13:13

answered Jan 28, 2014 at 9:36

David Ranieri

41.2k8 gold badges58 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Lundin Over a year ago

@MIIJ If you find an answer helpful (and correct), then thank them by up-voting the answer. Click on the arrow pointing upwards on the left side of the post. So in this case maybe up-vote both answers and accept the one you liked best (which you already did).

MIIJ Over a year ago

@Lundin, thanks for the tip, I tried before but it seems I don't have enough "reputation" to do so. Will do so as soon as I can.

MIIJ Over a year ago

@Alter Mann, Is the following correct? [if ((p = strchr(buf, '\n')) != NULL) //if the buf holds a '\n' value (return key)]...[ *p = '\0'; //the p char variable is set to null-terminator, signifying the end of a string]...[ x = (int)strtol(buf, &p, 10); //x is the parsing, at base 10, from the chars in the buf, until the value of p, to int.]...[ if (p == buf || *p != '\0') // if p hasn't been parsed, that it is exactly equal to the buffer values //2) I don't understand the 2nd entity(when it is equal to only 'return')?] ... when does it check for letters?

David Ranieri Over a year ago

@MIIJ, you can translate this as: if user types nothing or strtol fails to read a number

MIIJ Over a year ago

@Alter Mann, thanks for your answer, I had failed to see that the "base 10" in the strtol was the filter for letters... 'a' does not have an int equivalent. Learning, learning.

Dineshkumar · Accepted Answer · 2014-01-28 09:13:47Z

1

The code works fine for integer also. The only mistake I found is while printing the sorry message, you are printing just i, it should be i+1.

    int i = 0, number[10] = {0};
    char buf[128] = {0};

    for (i = 0; i < 10; i++)
    {
      printf("Please input number %d : ", i+1);

         while(scanf("%d", &number[i]) != 1)
      {
         scanf("%s", &buf);
         printf("Sorry, [%s] is not a number. Please input number %d : ", &buf, i+1);
      }
    }

    for (i = 0; i < 10; i++)
    {
    printf("\n Number %d is %d", (10-i), number[9-i]);
    }

answered Jan 28, 2014 at 9:13

Dineshkumar

1,5585 gold badges24 silver badges52 bronze badges

Collectives™ on Stack Overflow

scanf check in while loop to restrict integer input

2 Answers 2

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related