PHP in_array issue

Question

so im messing around with some php and for some reason in_array() won't pickup if something is within the array, correctly?

index.php:

<form action="login.php" method="get">
    <input name="username" type="text" />
    <input name="password" type="password" />
    <input id="submit" type="submit" />
</form>

login.php:

    <?php
    $username = $_GET["username"];
    $password = $_GET["password"];
        include('data/user_data.php');
        if(in_array($username, $users)):
            echo "in array";
        else: echo "not in array";
        endif;

?>

user_data.php:

<?php $users = array(
dextermb => array("dextermb", "password"),
tonymb => array("tonymb", "password2")
)
?>

When inputting "dextermb" or "tonymb" into username and submitting I get the result "not in array" even though it is in the array?

Thoughts on what might be the issue?

You can't use in_array() with a nested array. array_key_exists would work fro you though. — John Conde
– John Conde, Commented Jan 13, 2014 at 12:51
Go with $users = array('dextermb' => 'password1', 'tonymb' => 'password2'); — Mave
– Mave, Commented Jan 13, 2014 at 12:52
using in_array() in login check in not an optimal solution.... use db call instead of... — ReNiSh AR
– ReNiSh AR, Commented Jan 13, 2014 at 12:58
Hope you're only fiddling with it - please make sure hard-coded username/password pairs won't end up in production ;) — JSmyth
– JSmyth, Commented Nov 15, 2014 at 23:42

jszobody · Accepted Answer · 2014-01-13 12:52:27Z

4

If this is your users array:

$users = array(
    'dextermb' => array("dextermb", "password"),
    'tonymb' => array("tonymb", "password2")
);

Then you want to simply do:

if(isset($users[$username])) {

Or alternatively:

if(array_key_exists($username, $users)) {

The username is the key in your $users array, the in_array method looks for values (and not nested values).

answered Jan 13, 2014 at 12:52

jszobody

29k6 gold badges66 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Night Over a year ago

Ah nice! Thats a nice way of doing it, probably would be easier to search the array using isset, rather than array_key_exists? *for example matching the password with the name?

jszobody Over a year ago

@Night That seems simplest to me, yeah

Night Over a year ago

As the password is always going to be the second position in the array, wouldn't you be able to search it by something like "$users[$username,2]" (I know my example doesn't work)

jszobody Over a year ago

@Night $users[$username][1] would get the password for that user

Suraj Rawat · Accepted Answer · 2014-01-13 13:06:33Z

0

Simply You can use a php built in function

     if(array_key_exists($username, $users)){
     echo "in array";
     }else{
          echo "not in array";
     }

answered Jan 13, 2014 at 13:06

Suraj Rawat

3,76326 silver badges33 bronze badges

Collectives™ on Stack Overflow

PHP in_array issue

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related