javascript code not working

Question

<script language="JavaScript" type="text/javascript">
    if (location.href.indexOf('?dest=') > 0)
        window.open('/about.aspx', '', '')
</script>

how do i make this work. Its in aspx file.

What exactly is happening? Can you be a little more descriptive about any errors or strange behavior caused by the code? — Andy E
– Andy E, Commented Jan 19, 2010 at 17:52
im sorry. im very confused. i have first aspx page with <a href="login.aspx?dest=#" .. which goes to second page when clicked on it. On second page when i click "enter" i goto third page which has this code. I want to carry the dest=# to third page and based on this if condition a window should open. how do i achieve that? — sinaw
– sinaw, Commented Jan 19, 2010 at 18:00
FYI, window.location.search will return just the portion of the URL following the question mark, the querystring. — Andrew Noyes
– Andrew Noyes, Commented Jan 19, 2010 at 18:02
so how do i carry the querystring to 3rd page from the 2nd page and us the if condition? — sinaw
– sinaw, Commented Jan 19, 2010 at 18:03

fil maj · Accepted Answer · 2010-01-19 20:14:52Z

2

The following script will test for the existence of the 'dest=' key in the current page's querystring, and if it exists, will open a window to about.aspx with the querystring appended to the URL.

<script language="JavaScript" type="text/javascript">
if (window.location.search.indexOf('dest=') > 0) {
    window.open('/about.aspx' + window.location.search, '', '');
}
</script>

answered Jan 19, 2010 at 20:14

fil maj

2,31216 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Aaron · Accepted Answer · 2010-01-19 17:55:18Z

0

Change the window.open line to

window.location = '/about.aspx';

Include the semicolon, which is missing in your code.

answered Jan 19, 2010 at 17:55

Aaron

7,1484 gold badges34 silver badges48 bronze badges

1 Comment

Pops Over a year ago

JavaScript doesn't strictly require a semicolon at the end of a statement.

Torez · Accepted Answer · 2010-01-19 22:20:47Z

0

Your issue is the location.href... part. It needs to be window.location.href...


if (window.location.href.indexOf('?dest=') > 0){
    window.open('/about.aspx'+window.location.search, '', '');
}

Cheers

edited Jan 19, 2010 at 22:20

answered Jan 19, 2010 at 18:04

Torez

1,9127 gold badges25 silver badges39 bronze badges

1 Comment

sinaw Over a year ago

how do i get the ?dest to the third page. can i do if (request.querystring('dest=') > 0){ window.open('/about.aspx', '', ''); } this is because i need to get the querystring from the previous page to this page

Collectives™ on Stack Overflow

javascript code not working

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related