creating linked List in c++

Question

I'm trying to create a linked list in c++ that inserts elements from the end. I have the following code

#include<iostream>

using namespace std;

//Define a structure
    struct Node{
        int info;
        Node* next;
    } *start, *newptr, *current, *ptr;

Node* createNewNode(int);
void insertEnd(Node*);
void display(Node*);

int main(){
    char ch='y';
    while(ch=='y')
    {
        int inf;
        //Initialize the start pointer to NULL
        start = NULL;

        //Prompt the user for information
        cout<<"Enter the information -> ";
        cin>>inf;

        //Call the function to create a new node
        newptr = createNewNode(inf);
        cout<<"New node created successfully \n";

        //Insert the node in the beginning
        insertEnd(newptr);

        //Traversal
        display(start);

        //Asks the user for input
        cout<<"Want to enter more -> ";
        cin>>ch;
    }


    return 0;

}

Node* createNewNode(int a)
{
    ptr = new Node;
    ptr->info = a;
    ptr->next = NULL;
    return ptr;
}

void insertEnd(Node* p)
{
    if(start == NULL){
        start = p;
        current = p;
    }else {
        current->next = p;
        current = p;
    }
}

void display(Node* p)
{
    while(p!=NULL){
        cout<<p->info<<"->";
        p=p->next;
    }
}

When I compile the program runs fine but it does not display the complete list. It only displays the number recently inserted in the list by the user. What's wrong with this code?

You have the list backwards...

V-X
– V-X

2013-12-28 17:44:54 +00:00
Commented Dec 28, 2013 at 17:44 — V-X
– V-X, Commented Dec 28, 2013 at 17:44
have you tried debugging?

V-X
– V-X

2013-12-28 17:47:02 +00:00
Commented Dec 28, 2013 at 17:47 — V-X
– V-X, Commented Dec 28, 2013 at 17:47
why the global variables. remove them.

Cheers and hth. - Alf
– Cheers and hth. - Alf

2013-12-28 17:51:36 +00:00
Commented Dec 28, 2013 at 17:51 — Cheers and hth. - Alf
– Cheers and hth. - Alf, Commented Dec 28, 2013 at 17:51

mkaes · Accepted Answer · 2013-12-28 17:51:16Z

2

Your start of the list is reset in every iteration.

int main(){
    char ch='y';
    while(ch=='y')
    {
        int inf;
        //Initialize the start pointer to NULL
        start = NULL; // remove this line and do it before the while loop

answered Dec 28, 2013 at 17:51

mkaes

14.2k10 gold badges56 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Utkarsh Akash Over a year ago

Thanks, mate! I would like to ask one more thing. When I run the program the cmd prompt window is triggered instantly but the program initializes after few seconds say, 10-15 sec. I have tried compiling with CodeBlocks, DevC++ and MSVC++.

Collectives™ on Stack Overflow

creating linked List in c++

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related