BATCH code random variable not working

Question

I'm developing a batch game, and I have come across an error during testing. It's best if I show you the code:

:move
set /a chance=%RANDOM% % 4 + 1
if %chance% == 1 goto randomitem
if %chance% == 2 goto randommonster
if %chance% == 3 goto safe
if %chance% == 4 goto trap
:randomitem
cls
echo You found an item!
echo Sorry! The items mechanism hasn't been added yet!
goto main
:randommonster
cls
echo A random monster attacks you!
echo Sorry! The monsters mechanism hasn't been added yet!
goto main
:safe
cls
echo You enter another dark room with 4 corridors.
goto main
:trap
cls
echo You fall into a trap!
echo Sorry! The traps mechanism hasn't been added yet!
goto main

For some reason, instead of having a chance of doing all 4 paths, it is only doing randomitem. I don't know how to fix this, please help me!

Thanks!

Magoo · Accepted Answer · 2013-12-23 08:15:54Z

2

You need to double the % used as a mod operator.

set /a chance=%RANDOM% %% 4 + 1

answered Dec 23, 2013 at 8:15

Magoo

80.8k8 gold badges68 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

BATCH code random variable not working

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related