Adding each value to an integer array

Question

Can you help me with my problem? I need to add values to my int array but all I get is an ArrayIndexOutOfBoundsException.

public static void numberSort(){

    int quantity = 0;
    int[] values = new int[quantity];
    int allocate = 0;

    quantity = Integer.parseInt(JOptionPane.showInputDialog("How many values do you wish to sort? : "));

    for(int x = 0; x <= values.length; x++){
        allocate = Integer.parseInt(JOptionPane.showInputDialog("Values you want to sort : "));

        values[allocate] = x;

        System.out.println(values[x]);
    }

int quantity = 0; int[] values = new int[quantity]; You are creating an array with size 0 — nachokk
– nachokk, Commented Dec 10, 2013 at 18:20

Vivin Paliath · Accepted Answer · 2013-12-10 18:26:23Z

2

int quantity = 0;    
int[] values = new int[quantity];

You're allocating an array with 0 locations, which is effectively a zero-length array. This means that it really doesn't have any valid locations, so you can't store anything into it. This is why you're getting an ArrayIndexOutOfBounds exception when you attempt to store anything inside the array.

You will have to move the line where you allocate values to the line after the line where you read in the value of quantity.

Your next problem is your for loop:

for(int x = 0; x <= values.length; x++)

Array indices run from 0 to array.length - 1. So typically the terminating condition for the for loop is x < values.length. If this was your code, you wouldn't have seen this exception. However, even if you fix this to make quantity a non-zero value, you will get the exception when you attempt to fill the array since values[array.length] is out of bounds. So you will have to change your for loop to:

for(int x = 0; x < values.length; x++)

I also noticed that you have values[allocate] = x;. What you want is values[x] = allocate;, since you want the xth element of the array.

edited Dec 10, 2013 at 18:26

answered Dec 10, 2013 at 18:20

Vivin Paliath

95.8k42 gold badges230 silver badges302 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

nachokk Over a year ago

nice catch values[allocate] = x +1:D

nachokk · Accepted Answer · 2013-12-10 18:29:13Z

2

This line is your problem

int quantity = 0;    
int[] values = new int[quantity];

You are creating an array with length 0. The length of an array is established when the array is created. After creation, its length is fixed.

Comments

Sean · Accepted Answer · 2013-12-10 18:23:35Z

0

Aside from creating an array of 0 length, your for loop end condition is incorrect. You wrote x <= values.length, but you should write x < values.length. Since arrays in Java are 0-indexed, that means the valid range of indices are 0 to values.length - 1.

answered Dec 10, 2013 at 18:23

Sean

4,48028 silver badges22 bronze badges

Comments

kviiri · Accepted Answer · 2013-12-10 18:24:19Z

0

I count three errors in there. The most significant one:

for(int x = 0; x <= values.length; x++){

Java arrays index from zero - that means that for example an array with length of 5 has indexes 0, 1, 2, 3 and 4. Anything beyond that in either direction results in the ArrayIndexOutOfBoundsException. Because you use <=, you read one value beyond what's allowed. Replace it with <.

Also, you initialize your array to size zero. That means you can't really use it. Initialize your array with quantity only once quantity has the correct value!

Finally, I believe you want values[x] = allocate;, not vice versa.

answered Dec 10, 2013 at 18:24

kviiri

3,3021 gold badge24 silver badges30 bronze badges

Collectives™ on Stack Overflow

Adding each value to an integer array

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related