How to pass parameter in onclick function in javascript

Question

Inside javaScript function i code like this...

function myFunction(){
.....

completeTreeView = completeTreeView + 
   "<li><input type='checkbox' id=" + name +
   " /><label for='item-0' onclick='myclicktest(\'' + result.name +
   '\')' >" + Address + "</label>";

.......
}

function myclicktest(name){
            alert(name);
}

How to pass and get the result.name

1) Don't append HTML as string, use createElement 2) don't use inline event handlers, use addEventListener instead. 3) the codehighlighting from SO already gives you the answer. — Christoph
– Christoph, Commented Dec 10, 2013 at 10:30

vmx · Accepted Answer · 2013-12-10 10:30:01Z

1

Does this work for you?

function myFunction() {
  // .....

  completeTreeView = completeTreeView + "<li><input type='checkbox' id=" + parent.node.name + " /><label for='item-0' onclick='myclicktest(\'" + result.name + "\')' >" + nodeNameIpAddress + "</label>";

  // .......
}

function myclicktest(name) {
  alert(name);
}

Just notice the quotes before and after result.name.

answered Dec 10, 2013 at 10:30

vmx

8,5074 gold badges24 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gourav · Accepted Answer · 2013-12-10 10:30:25Z

1

The approach seems to be correct.

Please check the single quote or double quote issues in javascript.

You can find the javascript issue in console if you are using firebug in firefox.

You can also check the "result.name" value in an alert to confirm that you are getting the value.

Thanks

answered Dec 10, 2013 at 10:30

Gourav

8233 gold badges10 silver badges24 bronze badges

1 Comment

Hariharan Over a year ago

given +1 for providing clue(quote). which help me to solve the problem

Prateek · Accepted Answer · 2013-12-10 10:41:09Z

1

Try this

<label><input type='checkbox' onclick='myclicktest(this);'>Checkbox</label>

function myclicktest(cb)
{
  display("Clicked, new value = " + cb.checked);
}

edited Dec 10, 2013 at 10:41

answered Dec 10, 2013 at 10:32

Prateek

6,9852 gold badges27 silver badges37 bronze badges

Comments

user3041160 · Accepted Answer · 2013-12-10 10:56:12Z

1

completeTreeView = completeTreeView + '<li><input type="checkbox" id="' + parent.node.name + '" /><label for="item-0" onclick="myclicktest(\'' + result.name + '\')">' + nodeNameIpAddress + '</label>';

Html attributes use " and it is better to use ' for javascript strings

So if you cannot reverse :

completeTreeView = completeTreeView + "<li><input type='checkbox' id=" + parent.node.name + " /><label for='item-0' onclick=\"myclicktest('" + result.name + "')\" >" + nodeNameIpAddress + "</label>";

edited Dec 10, 2013 at 10:56

answered Dec 10, 2013 at 10:29

user3041160

6743 silver badges5 bronze badges

3 Comments

Hariharan Over a year ago

but in my case i need to use ' instead of "

Hariharan Over a year ago

i made it reverse... use " instead of '

Hariharan Over a year ago

given +1 for providing clue to fix my issue.

CBusBus · Accepted Answer · 2013-12-10 10:32:33Z

0

One option you have is define the parameter when you bind the event.

function bindEvToThing(str, el)
{
    var name = str
    el.onmouseup = function()
    {
        alert(name)
    }
}

answered Dec 10, 2013 at 10:32

CBusBus

2,3672 gold badges18 silver badges28 bronze badges

Comments

Hariharan · Accepted Answer · 2013-12-10 10:54:16Z

0

i fixed it... i used as below.

completeTreeView = completeTreeView + "<li><input type='checkbox' id="+ name+" /><label for='item-0' onclick='myclicktest(\"" +  Address + "\")' >"+ Address+"</label>";

Thanks to all for providing me clue to fix it.

answered Dec 10, 2013 at 10:54

Hariharan

3,2834 gold badges22 silver badges31 bronze badges

6 Comments

Christoph Over a year ago

Did none of the other answer solve your problem so that you have to post a different one?

Hariharan Over a year ago

yes @Christoph.. i got syntax error of all the above answer in my way of approach....

Christoph Over a year ago

There are three other answers telling you exactly this! There is no need for this absolutely redundant answer. Instead you could give credits to one of those answers by accepting them as correct answer...

Hariharan Over a year ago

None of the answer helped me, but gave me clue to fix the issue. you can check my answer. But i provide +1(upvote) to them for providing me clue @Christoph.

Christoph Over a year ago

I don't see any difference from your answer to the others other than the different variable names which comes from you changing your question after they wrote their answers.

|

Collectives™ on Stack Overflow

How to pass parameter in onclick function in javascript

6 Answers 6

Comments

1 Comment

Comments

3 Comments

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

1 Comment

Comments

3 Comments

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related