Putting multiple String into an ArrayList

Question

So I'm doing this:

        int len = lv.getCount();

    List<String> Cool = null;
    SparseBooleanArray checked = lv.getCheckedItemPositions();
    for (int i = 0; i < len; i++)
        if (checked.get(i)) {
            String item = String.valueOf(names.get(i));
            int start = item.lastIndexOf('=') + 1;
            int end = item.lastIndexOf('}');
            String TEST = item.substring(start, end);

            Log.d("Log", TEST);

            Cool = new ArrayList<String>();

            Cool.add(TEST);

        }


            String NEW = StringUtils.join(Cool, ',');

            Log.d("Log", NEW);

Which evey time replaces the thing in the list with whatever the next item is. How do i make it put the strings after each other.

Thanks for the help.

Florian Groetzner · Accepted Answer · 2013-12-07 21:36:40Z

2

List<String> Cool = new ArrayList<String>();

create the list at the top

Cool = new ArrayList<String>();

and delete this line because it will always create a new list what you dont want

answered Dec 7, 2013 at 21:36

Florian Groetzner

5123 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Elliott Frisch · Accepted Answer · 2013-12-07 21:36:55Z

1

You're constructing a new ArrayList in every iteration of your for loop

 Log.d("Log", TEST);
 Cool = new ArrayList<String>(); // NOT HERE!!!!
 Cool.add(TEST);

construct it once, outside the loop

List<String> Cool = new ArrayList<String>(); // also Cool should be cool.

answered Dec 7, 2013 at 21:36

Elliott Frisch

202k20 gold badges166 silver badges265 bronze badges

Comments

Itai Hay · Accepted Answer · 2013-12-07 21:37:51Z

the reason it keeps resetting the list is because you initialized the List in a loop. Initialize it outside the loop and the algorithm will work.

Initialization:

Cool = new ArrayList();

Corrected code:

int len = lv.getCount();

List<String> Cool = new ArrayList<String>();
SparseBooleanArray checked = lv.getCheckedItemPositions();
for (int i = 0; i < len; i++)
    if (checked.get(i)) {
        String item = String.valueOf(names.get(i));
        int start = item.lastIndexOf('=') + 1;
        int end = item.lastIndexOf('}');
        String TEST = item.substring(start, end);

        Log.d("Log", TEST);

        Cool.add(TEST);

    }


        String NEW = StringUtils.join(Cool, ',');

        Log.d("Log", NEW);

Collectives™ on Stack Overflow

Putting multiple String into an ArrayList

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related