javascript loop image slideshow

Question

var imag = document.getElementById('contentimage');
            var imagarr = ["images/contimgtwo.jpg","images/contimg.jpg"]
            //var convertimg = imagarr[i].toString();
            var runtext = function(){
                for (i=0;i<imagarr.length;i++){

                imag.src=imagarr[i];
                }
            }
      setTimeout(runtext,5000);

CSS:

   #contentimage { 
    display:block; 
    top:1600px;
    width:500px; 
    height:400px; 
    position:absolute;
} 

    #contentimage:hover { 
        opacity:0.5; 
        cursor:crosshair;
    }

I'm trying to make a image slideshow using a for loop, the idea is that it will provide the .src path with the image path from the array, however the problem is the .src=" " method requires you to " " so I can't call the array and so it doesn't find the image, any way around this?

Krasimir · Accepted Answer · 2013-11-24 08:01:40Z

2

You should not loop the whole array in your runtext function. Doing that you actually apply only the last value of the array and always the last image is shown. Here is a modification of your script which may work:

var imag = document.getElementById('contentimage');
var imagarr = ["images/contimgtwo.jpg", "images/contimg.jpg"];
var index = 0, interval;
var runtext = function(){
    imag.src = imagarr[index];
    if(index < imagarr.length-1) {
        index += 1;
    } else {
        index = 0;
    }
    interval = setTimeout(runtext, 5000);
}
var stopText = function() {
    clearTimeout(interval);
}
interval = setTimeout(runtext, 5000);

I added a function which stops the slideshow. You still go through all the elements of the array, but the index is incremented on every runtext call.

answered Nov 24, 2013 at 8:01

Krasimir

13.6k4 gold badges45 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Praveen Over a year ago

+1 you approach is the right to solve this problem. I have found his problem but mine is not a working solution.

Collectives™ on Stack Overflow

javascript loop image slideshow

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related