Wordwrapping php-> javascript

Question

I have this text in my mysql-database:

Hi
how are you?

Working (php):

echo $row['text'];

Now working:

<script>
test = "<?php echo $comment; ?>";
document.writeln(test.parseURL().parseUsername().parseHashtag());
</script>

The error is nothing printed.

The javascript function:

 <script>
String.prototype.parseURL = function() {
return this.replace(/[A-Za-z]+:\/\/[A-Za-z0-9-_]+\.[A-Za-z0-9-_:%&~\?\/.=]+/g, function(url) {
return url.link(url);
});
};

String.prototype.parseUsername = function() {
return this.replace(/[@]+[A-Za-z0-9-_]+/g, function(u) {
    var username = u.replace("@","")
    return u.link("http://url.com/"+username);
});
};

String.prototype.parseHashtag = function() {
return this.replace(/[#]+[A-Ö–a-ö0-9-_]+/g, function(t) {
    var tag = t.replace("#","")
    return t.link("/?p=tagga&q="+tag);
});
};
</script>

But if I have it without the line break so it works Hi! How are you?

Anyone know how I can solve this?

Niet the Dark Absol · Accepted Answer · 2013-11-23 20:46:14Z

2

Always look at the rendered output. In this case:

test = "Hi
how are you?";

This is clearly invalid (unterminated string constant).

When dumping PHP variables into JS, ALWAYS use json_encode.

test = <?=json_encode($row['text'])?>;

Output:

test = "Hi\nhow are you?";

answered Nov 23, 2013 at 20:46

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bart · Accepted Answer · 2013-11-23 21:33:31Z

0

Javascript literal multiline strings are nothing like multiline line strings in PHP. Either escape the newline e.g.

var text = 'Hi \
how are you?'

Or make it one single line e.g.

var text = 'Hi\nHow are you?';

edited Nov 23, 2013 at 21:33

answered Nov 23, 2013 at 20:46

Bart

17.4k5 gold badges63 silver badges81 bronze badges

2 Comments

Andreas Over a year ago

To save in database: $ text = mysql_real_escape_string ($ _POST ['tag']); What code should I use instead?

Bart Over a year ago

Saving is not the problem. It's the ouput. You will need to make sure it's proper javascript.

Collectives™ on Stack Overflow

Wordwrapping php-> javascript

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related