php/mysql Update not working [closed]

Question

Closed. This question does not meet Stack Overflow guidelines. It is not currently accepting answers.

Questions asking for code must demonstrate a minimal understanding of the problem being solved. Include attempted solutions, why they didn't work, and the expected results. See also: Stack Overflow question checklist

Closed 12 years ago.

Improve this question

I am testing a password update process with php/mysql. I don't get any error on submit, but my values are not updated. Any ideas?

if (!empty($_POST['password']) && !empty($_POST['password2'])){
    $id = $_GET['id'];
    $password = md5(mysql_real_escape_string($_POST['password']));
    $sql = mysql_query("UPDATE users SET `Password` = '$password' WHERE UserID = '$id'");
    if ($sql){
        echo $password, $id;
    }else{
        echo mysql_error();
    }
}

More debugging: print out the resulting query, try it in phpmyadmin etc. Does your code reach the echo $pw, $id at all? — mario
– mario, Commented Nov 23, 2013 at 5:01
You're combining $_GET and $_POST. Is this deliberate, or should $_GET['id'] be $_POST['id'] instead? — Pat J
– Pat J, Commented Nov 23, 2013 at 5:03
Try $query = "UPDATE users SET Password = '$password' WHERE UserID = '$id'" and debug $query variable and check if it will work in your backend. — Edper
– Edper, Commented Nov 23, 2013 at 5:04
That's probably the answer @PatJ. You should post that as an answer. ;-) — Edper
– Edper, Commented Nov 23, 2013 at 5:05
I'm passing an id in the url to verify the user when they retrieve the link in their inbox. I am try to GET that id from the URL to compare it with what I have stored. — Mark Kamyszek
– Mark Kamyszek, Commented Nov 23, 2013 at 20:50

Teej · Accepted Answer · 2013-11-23 05:05:00Z

1

Just a hunch. Try removing quotation marks around the variable, $id:

if (!empty($_POST['password']) && !empty($_POST['password2'])){
    $id = $_GET['id'];
    $password = md5(mysql_real_escape_string($_POST['password']));
    $sql = mysql_query("UPDATE users SET `Password` = '$password' WHERE UserID = {$id}");
    if ($sql){
        echo $password, $id;
    }else{
        echo mysql_error();
    }
}

answered Nov 23, 2013 at 5:05

Teej

12.9k9 gold badges76 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pat J · Accepted Answer · 2013-11-23 05:16:00Z

1

You've combined $_GET and $_POST. Try changing $_GET['id'] to $_POST['id']. If that doesn't work, try adding

var_dump( $_POST );
var_dump( $_GET );

to your code. That might help you debug.

answered Nov 23, 2013 at 5:16

Pat J

53610 silver badges22 bronze badges

4 Comments

Teej Over a year ago

It is possible to have $_POST and $_GET though. But you are right that a little more information from the OP is helpful.

Pat J Over a year ago

True. If nothing else, it'll eliminate $_GET/$_POST as the problem.

Mark Kamyszek Over a year ago

I'm passing an id in the url to verify the user when they retrieve the link in their inbox. I am try to GET that id from the URL to compare it with what I have stored. ../reset_password.php?id=1

Pat J Over a year ago

Ah, OK. Make sure, though, that you ensure that your ID is an integer (right?) by doing something like $id = intval( $_GET['id'] );. See Data Validation for more details.

Rahul · Accepted Answer · 2013-11-23 21:11:35Z

0

mysql_real_escape_string returns TRUE/FALSE

just use it like this

if(mysql_real_escape_string($_POST['password']))
{
    $password = md5($_POST['password']);
}

It will work now !

Suggestion :

Go one way. Either GET or POST

answered Nov 23, 2013 at 21:11

Rahul

1,1691 gold badge11 silver badges21 bronze badges

Comments

Mark Kamyszek · Accepted Answer · 2013-11-24 14:55:14Z

0

This seemed to work:

$id = $_REQUEST['id'];
if (!empty($_POST['password']) && !empty($_POST['password2'])){
    $password = md5(mysql_real_escape_string($_POST['password']));
    $sql = mysql_query("UPDATE users SET Password = '".$password."' WHERE UserID = '".$id."'");
    if ($sql){
        echo "Password reset.";
        echo "<meta http-equiv='refresh' content='1;index.php' />";
    }else{
        echo mysql_error();
    }
}else{
?>
<form role="form" action="[Leave blank]" method="post" name="resetpassword" id="resetpassword">

edited Nov 24, 2013 at 14:55

answered Nov 23, 2013 at 21:08

Mark Kamyszek

3982 gold badges5 silver badges15 bronze badges

2 Comments

Pat J Over a year ago

One more check you might want to do: $_POST['password'] == $_POST['password2'].

Mark Kamyszek Over a year ago

Tks! Just trying to get it to work at this point, then on to error/form checking.

Sico · Accepted Answer · 2013-11-23 05:01:54Z

-2

Is it the right ID that you are trying to update?

answered Nov 23, 2013 at 5:01

Sico

1,1831 gold badge10 silver badges16 bronze badges

5 Comments

Teej Over a year ago

add this is as a comment to the question if you're not answering the question.

Sico Over a year ago

It is an answer but in the form of a question

Teej Over a year ago

So its an answer in a form of a question. Really?

Teej Over a year ago

ok then Sico. No problem :)

Sico Over a year ago

Sorry, up way past my bedtime in the UK :)

Collectives™ on Stack Overflow

php/mysql Update not working [closed]

5 Answers 5

Comments

4 Comments

Comments

2 Comments

5 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

4 Comments

Comments

2 Comments

5 Comments

Linked

Related