PHP Class variable access question

Question

I'm having trouble accessing a class' variable.

I have the functions below in the class.

class Profile { 

    var $Heading;

    // ...

    function setPageTitle($title)
    {
        $this->Heading = $title;
        echo 'S: ' . $this->Heading;
    }

    function getPageTitle2()
    {       
        echo 'G: ' . $this->Heading;
        return $this->Heading;
    }

// ...
}

Now when I run the method $this->setPageTitle("test") I only get

G: S: test

What's wrong with the getPageTitle2 function? Heading is public btw. Please help!

Thanks guys!

the whole code is located at www.fearghal.com/Untitled-1.phps the function names are SetContent() and getPageContents() ... they called the functions is questions. — Fearghal
– Fearghal, Commented Jan 6, 2010 at 14:44

troelskn · Accepted Answer · 2010-01-06 14:23:33Z

4

Now when I run the method $this->setPageTitle("test") I only get

G: S: test

That sounds implausible. Are you sure you're not running:

$this->getPageTitle2();
$this->setPageTitle("test");

PHP - like most programming languages - is an imperative language. This means that the order in which you do things matters. The variable $this->Header is not set at the time where you call getPageTitle2.

edited Jan 6, 2010 at 14:23

answered Jan 6, 2010 at 14:18

troelskn

118k27 gold badges135 silver badges156 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Fearghal Over a year ago

well i have other functions //(the only one that calls the set function) function getPageContents() { $this->setPageTitle("test"); } and the other function setContent // runs the getPageTitle2 { echo '<div id="page_title">'.$this->getPageTitle2().'</div>'; } so i didn't think it mattered the placement of functions within a class. Perhaps the getPageContents() must be placed above the Set()?

user229044 Over a year ago

@Fergs Placement of the method in the class doesn't matter, this I can guarantee. Somewhere in your code, you are explicitly calling getPageTitle2(), before you call setPageTitle() - there is no implicit or otherwise automagical way to call a method named getPageTitle2.

Fearghal Over a year ago

thats what i figured: i;ve uploaded the code to www.fearghal.com/Untitled-1.phps Its semi large but the SetContent and getPageContents are in there and call the functions in question...could you have a look?

troelskn Over a year ago

@fergs That code is just a class. It won't do anything at all. Your problem likely lies in the code that uses the class.

Eric · Accepted Answer · 2010-01-06 14:14:52Z

1

If you have "G: S: test" it means you called getPageTitle2 before setPageTitle ! It looks normal then : I suggest first set then get.

answered Jan 6, 2010 at 14:14

Eric

5,37110 gold badges39 silver badges47 bronze badges

Comments

Hiyasat · Accepted Answer · 2010-01-06 14:48:25Z

0

you have to declare the Heading and title out of the function ... i dont know if you already did that

see the order of calling the functions

edited Jan 6, 2010 at 14:48

answered Jan 6, 2010 at 14:02

Hiyasat

8,9667 gold badges36 silver badges60 bronze badges

1 Comment

Fearghal Over a year ago

yes, my class starts like: class Profile { var $Heading; but does $title need to as well even though its feed straight into the function?

gmadd · Accepted Answer · 2012-01-10 14:51:00Z

0

class Profile { 

var $Heading;

// ...

function setPageTitle($title)
{
    $this->Heading = $title;
    echo 'S: ' . $this->Heading;
}

function getPageTitle2()
{       
    echo 'G: ' . $this->Heading;
    return $this->Heading;
}

// ...
}

I am guessing you are doing something like this:

$profile = new Profile();
$profile->setPageTitle("test");
$profile->getPageTitle2();

and that this would result in the following output:

S: testG: test

and that if you echo $profile you will just get

test

so what do you think is the problem or what are you not accomplishing that you want to?

also I would probably declare $Heading as

private $heading;

edited Jan 10, 2012 at 14:51

gmadd

1,1529 silver badges18 bronze badges

answered Jan 6, 2010 at 14:25

kelly

1

Collectives™ on Stack Overflow

PHP Class variable access question

4 Answers 4

4 Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related