I am trying to create an ArrayList of Card objects. This will represent the users hand. I have not really worked with arraylist before so any help would be appreciated. Below is my current attempt:
class Hand {
public static final int CARDS = 4;
ArrayList<Card> hand = new ArrayList<Card>();
public Hand(){
for(int i=0; i < CARDS; i++){
hand.add(new Card());
}
}
Is this correct? and Specially if it is not correct, could somebody point out what I am doing wrong?
The easiest way to find out is to compile the program and run it. :)
That being said, it looks fine. The only thing I would change is:
ArrayList<Card> hand = new ArrayList<Card>();
to:
List<Card> hand = new ArrayList<Card>();
If you are using Java 7, you can get rid of the second generic-parameter:
List<Card> hand = new ArrayList<>();
Typing with interfaces is a good habit to get into since it is easier for you to switch implementations later (like if you wanted to use LinkedList<T> instead).
Foo<Generic> var = new Foo();
Foo<Generic> var = new Foo<>();. If you just do new Foo(), that's a raw type just like in Java 5 or 6, and you'll get the same unchecked cast warning.Overall it seems correct, however you are just adding new Card objects without any sort of (known) randomization, so all the cards will be the same as far as I'm aware.
Seems good, just a small suggestion:
ArrayList<Card> hand = new ArrayList<Card>();
to:
List<Card> hand = new ArrayList<>(); //in java 7 the diamond symbol in right is allowed
main()function and run it!