c# not all code paths return a value error in simple method

Question

Simple program for class to count words and getting the error above and it driving me mad.

int words; //variable to hold word count.

//WordCount methos will count the spaces and punciation.
private int WordCount(string str)
{
    int words = 0; //the number of words counted

    //count the white spaces and punctuation.
    foreach (char ch in str)
    {
        if (char.IsWhiteSpace(ch))
        {
            words++;
        }
        if (char.IsPunctuation(ch))
        {
            words++;
        }

        //return number of words
        return words;
    }
}

Move return outside the foreach loop.

Alessandro D'Andria
– Alessandro D'Andria

2013-11-13 19:23:14 +00:00
Commented Nov 13, 2013 at 19:23 — Alessandro D'Andria
– Alessandro D'Andria, Commented Nov 13, 2013 at 19:23

Tomzan · Accepted Answer · 2013-11-13 19:21:16Z

8

If the string will be empty the return command will not be executed..

Use this instead:

//WordCount methos will count the spaces and punciation.
private int WordCount(string str)
{
    int words = 0; //the number of words counted

    //count the white spaces and punctuation.
    foreach (char ch in str)
    {
        if (char.IsWhiteSpace(ch))
        {
            words++;
        }
        if (char.IsPunctuation(ch))
        {
            words++;
        }
   }

   //return number of words
   return words;
}

answered Nov 13, 2013 at 19:21

Tomzan

2,81816 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mosep Over a year ago

Thanks, now having the issue tying to use the returned int of words in an output message box in the button press method. If I declare the int variable before the WordCount method it get stuck with a default value of 0.

Habib · Accepted Answer · 2013-11-13 19:23:15Z

3

Your code is returning from inside of foreach loop, if the parameter passed is null, you will get an exception, if it is an empty string, execution will not enter the loop hence the error.

Your current method is also incorrect logically since it will return after first iteration, possibly giving you incorrect result. Your return statement should be outside of foreach loop

answered Nov 13, 2013 at 19:23

Habib

224k30 gold badges420 silver badges446 bronze badges

Comments

AndySavage · Accepted Answer · 2013-11-13 19:23:26Z

2

Your method is declared as int, which means it MUST return a value. The compiler is complaining that this is not guaranteed to be the case. Specifically if the string is empty your foreach is not entered and no return statement is executed.

On another note, having a forced return on the first iteration makes the foreach pointless.

answered Nov 13, 2013 at 19:23

AndySavage

1,7691 gold badge21 silver badges34 bronze badges

2 Comments

Mosep Over a year ago

Thanks, now I have to resolve the not looping as you notes on the return.

AndySavage Over a year ago

I believe the code provided by Tomzan matches what you were trying to do.

Collectives™ on Stack Overflow

c# not all code paths return a value error in simple method

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related