Mysql Insert query in Java

Question

Im getting an sql syntax error somewhere at the end of this code line, i have tweaked it and mixed a bit with it but so far i haven't solved it.

 strSQL="INSERT INTO " + tableName + " VALUES " + "(" + id + ",'" + rname + "','" + rfn + "','" + rmn + ")";

Any help appreciated!

This is just aside your question but You should (seriously) have a look at what is SQL Injection and how to avoid it. — benzonico
– benzonico, Commented Nov 6, 2013 at 13:29
Yea i know im used with doing it in php, though this is just a school assignment so im not going to bother making it sql injection safe. — Looptech
– Looptech, Commented Nov 6, 2013 at 13:32

juergen d · Accepted Answer · 2013-11-06 13:28:44Z

6

You are missing a quote at the end

+ rmn + " )";
         ^---------here

But actually you should rather use Prepared Statements.

answered Nov 6, 2013 at 13:28

juergen d

205k40 gold badges303 silver badges377 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Konstantin Yovkov · Accepted Answer · 2013-11-06 13:34:07Z

1

You have missed several ' signs. (not only in the end, but before and after the id)

strSQL="INSERT INTO " + tableName + " VALUES " + "('" + id + "','" + rname + "','" + rfn + "','" + rmn + "')";

Not related to the question, but strongly related to the proper creation of queries in Java:

You should avoid constructing queries with String contatenation. Instead, use PreparedStatement parameters. For example, you query would look like this:

strSQL="INSERT INTO " + tableName + " VALUES (?, ? , ? , ?)";

edited Nov 6, 2013 at 13:34

answered Nov 6, 2013 at 13:29

Konstantin Yovkov

63k9 gold badges107 silver badges152 bronze badges

1 Comment

Math Over a year ago

if the id is a number doesn't need the quote

Suresh Kamrushi · Accepted Answer · 2013-11-06 13:29:28Z

0

There is no field name specified.write like this

INSERT INTO tbl_name (col1,col2) VALUES(val1, vale2);

Check url:http://dev.mysql.com/doc/refman/5.6/en/insert.html

answered Nov 6, 2013 at 13:29

Suresh Kamrushi

16.2k13 gold badges79 silver badges93 bronze badges

4 Comments

Looptech Over a year ago

i dont need to specify them in java.

Suresh Kamrushi Over a year ago

@Looptech: my bad than. Thanks for bringing up.

Hussain Akhtar Wahid 'Ghouri' Over a year ago

@SureshKamrushi : if you are entering all the columns in the values , then you don't need to specify column names

Hussain Akhtar Wahid 'Ghouri' Over a year ago

@Looptech : where it says in java that you don't need to specify column names in java.

Collectives™ on Stack Overflow

Mysql Insert query in Java

3 Answers 3

Comments

1 Comment

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related