PHP Conditional embedded within another conditional

Question

Ok, the code below works. I've crated a custom field for scores from Rotten Tomatoes that I can add to my Blu-Ray reviews. Based on its score (above 60 will get a "fresh" rating, below a "rotten") it'll display the appropriate image.

This works fine.

But...it also displays on every page; even those without scores assigned yet.

<?php
  global $wp_query;
  $postid = $wp_query->post->ID;

$result = ( get_post_meta($postid, 'ecpt_tomatometer', true));

if ($result >= 60) {
    echo '<img src="/images/misc/fresh.png" width="102" height="25"> <span class=tomatometer>' . get_post_meta($postid, 'ecpt_tomatometer', true) . '%</span><br />';
  } 
else {
    echo '<img src="/images/misc/rotten.png" width="102" height="25"> <span class=tomatometer>' . get_post_meta($postid, 'ecpt_tomatometer', true) . '%</span><br />';
  } 
?>

Now below is another snippet of code that works, yet I can't seem to intertwine the two. This (below) basically says "if there's something in the custom field, then display the code (above), otherwise don't display anything.

So I've got both parts of what I want to work, but I can't seem to get them to work together.

<?php
global $wp_query;
$postid = $wp_query->post->ID;
if( get_post_meta($postid, 'tomatometer', true)) 
{ ?>
This won't show up if there's nothing in the field.
<?php } 
           elseif( get_post_meta($postid, 'ecpt_tomatometer', true)) { 
?>
this will display all of the information I need it to.
<?php } ?>

Ideas?

Billy · Accepted Answer · 2013-10-21 21:55:43Z

1

Do the result comparison only if the result has a value (assuming null or false if no rating).

global $wp_query;
$postid = $wp_query->post->ID;
if($result = get_post_meta($postid, 'ecpt_tomatometer', true)){
if ($result >= 60) {
        echo '<img src="/images/misc/fresh.png" width="102" height="25"> <span class=tomatometer>' . get_post_meta($postid, 'ecpt_tomatometer', true) . '%</span><br />';
} 
else {
        echo '<img src="/images/misc/rotten.png" width="102" height="25"> <span class=tomatometer>' . get_post_meta($postid, 'ecpt_tomatometer', true) . '%</span><br />';
}
}

answered Oct 21, 2013 at 21:55

Billy

1656 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arthur Nicoll · Accepted Answer · 2013-10-21 22:02:12Z

0

not sure of the possible values of $result but I would try something like:

<?php
  global $wp_query;
  $postid = $wp_query->post->ID;

$result = ( get_post_meta($postid, 'ecpt_tomatometer', true));
if (!($result===false) && intval($result) > 0)
{
if ($result >= 60) {
    echo '<img src="/images/misc/fresh.png" width="102" height="25"> <span class=tomatometer>' . get_post_meta($postid, 'ecpt_tomatometer', true) . '%</span><br />';
  } 
else {
    echo '<img src="/images/misc/rotten.png" width="102" height="25"> <span class=tomatometer>' . get_post_meta($postid, 'ecpt_tomatometer', true) . '%</span><br />';
  }
} 
?>

This should work.

answered Oct 21, 2013 at 22:02

Arthur Nicoll

3911 gold badge2 silver badges9 bronze badges

2 Comments

user34872 Over a year ago

This one didd the trick for me. I have no idea why, but it worked. Thank you.

Billy Over a year ago

This won't display a a rating of zero (if that's possible). And if you want to optimize it, you don't need to call get_post_meta the second time as you already have its value stored in $result.

Collectives™ on Stack Overflow

PHP Conditional embedded within another conditional

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related