Why does my Do While loop terminate?

Question

I am trying to implement a server with multiple commands. Most commands work so far except that I want the server to send a warning to the client when the client writes an argument to the quit command. (I.E. quit xyz) and lets the user try again rather than exiting the server. Unfortunately the server quits whether the user types quit or quit arguments.

bool done = false;

do
{
    if(strcmp(cmd, "quit") == 0)
    {
        if(strcmp(argument, "") != 0)
            strcpy(replyMsg, "504 Command not implemented for that parameter.\n");
        else
        {
            strcpy(replyMsg,"221 Service closing control connection.\n");
            done = true;
        }
    }
    while(strcmp(cmd, "quit") != 0 && done != true);

Thanks everyone. I found out that my mistake was in the client side and the missing bracket is just a typo. I don't know how to properly close topics or should I just delete it? — Anderson Santana
– Anderson Santana, Commented Oct 16, 2013 at 21:37
Up to you. You might also fix the typo in your question and add an answer to your own own question in which you explain what was wrong on the client side. In any case, I believe my own answer about the fact checking cmd is redundant still apply. — jlliagre
– jlliagre, Commented Oct 17, 2013 at 2:11

jlliagre · Accepted Answer · 2013-10-15 19:08:26Z

1

I would just use:

...
}
while(!done);

There is no point checking cmd.

answered Oct 15, 2013 at 19:08

jlliagre

31.1k7 gold badges65 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

samairtimer · Accepted Answer · 2013-10-15 19:10:34Z

0

Your loop structure seems missing brace before while to be wrong, or it is a typo. Check it first and lets see the correct code.

answered Oct 15, 2013 at 19:10

samairtimer

8862 gold badges12 silver badges29 bronze badges

Comments

damienfrancois · Accepted Answer · 2013-10-15 19:54:16Z

0

Remove your test on the cmd in the while condition. Whenever he user chooses 'quit' it evaluates to false, so the whole expression is false due to the conjunction and the loop exits

answered Oct 15, 2013 at 19:54

damienfrancois

60.4k9 gold badges116 silver badges128 bronze badges

Collectives™ on Stack Overflow

Why does my Do While loop terminate?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related