Unable to create array for recursive function

Question

I have a simple function checkReplies() which checks the reply_id and if the reply_id is not equal to 0, calls himself and checks again. Now I need to create a array ffor the outputs it generate, but I am unable to do it, the array outputs only the last element

function checkReplies( $rnid ){
    $r_notes = array();
    include_once('include/class.dbc.php');
    $dbo=new dbc();
    $db=$dbo->dbconnect();
    if( $rnid > 0 ): 
    $qry_rn = "SELECT note_subject,note_body,reply_note_id FROM tbl_notes WHERE note_id = '$rnid' ORDER BY note_date DESC";
    $rslt_rn = $dbo->executeQuery( $qry_rn );
    $reply = '<p style="border : none;">';
    $reply .= $rslt_rn[0]['note_subject'].'<br />'.$rslt_rn[0]['note_body'];
    $reply .= '('.$rslt_rn[0]['reply_note_id'].')';
    $reply .= '</p>';

    echo $reply;
    $r_notes[] = $reply;
    checkReplies( $rslt_rn[0]['reply_note_id'] );
    endif;
    return $r_notes;
}
$display = checkReplies( $rnid );
var_dump($display);

How to create the array of the outputs ?

OlivierH · Accepted Answer · 2013-09-24 09:31:42Z

1

Just give your array as an optional parameter of your function. And, return the recursive call of your function.

Almost all recursives functions are built the same way : at the beggining, a condition making your recursivity stop or continue : this is called the "terminating case". Then, if this break condition is not true, make what you got to do and return the recursive call of the function.

function checkReplies( $rnid, &$r_notes = array() ){

    include_once('include/class.dbc.php');
    $dbo=new dbc();
    $db=$dbo->dbconnect();

    if($rnid == 0)
            return $r_notes;

    $qry_rn = "SELECT note_subject,note_body,reply_note_id FROM tbl_notes WHERE note_id = '$rnid' ORDER BY note_date DESC";
    $rslt_rn = $dbo->executeQuery( $qry_rn );

    $reply = '<p style="border : none;">';
    $reply .= $rslt_rn[0]['note_subject'].'<br />'.$rslt_rn[0]['note_body'];
    $reply .= '('.$rslt_rn[0]['reply_note_id'].')';
    $reply .= '</p>';

    echo $reply;

    $r_notes[] = $reply;

    return checkReplies( $rslt_rn[0]['reply_note_id'], $r_notes );

}


$display = checkReplies( $rnid );

var_dump($display);

edited Sep 24, 2013 at 9:31

answered Sep 24, 2013 at 9:25

OlivierH

3,8801 gold badge22 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Nitish Over a year ago

:( its the same output coming

Virus721 Over a year ago

The array should probably be passed as a reference, only objects are automatically passed as references.

OlivierH Over a year ago

Edited, i forgot to give array as reference and to return the recursive call.

arilia · Accepted Answer · 2013-09-24 09:41:17Z

1

try this

$r_notes = array_merge($r_notes, checkReplies( $rslt_rn[0]['reply_note_id'] ));

instead of

$r_notes[] = $reply;

checkReplies( $rslt_rn[0]['reply_note_id'] );

I edited, sorry for the error.

edited Sep 24, 2013 at 9:41

answered Sep 24, 2013 at 9:27

arilia

9,3982 gold badges24 silver badges47 bronze badges

3 Comments

Nitish Over a year ago

Warning : Warning: array_merge() [function.array-merge]: Argument #1 is not an array in xxxx.php

Nitish Over a year ago

I used $r_notes[] = array_merge($r_notes, checkReplies( $rslt_rn[0]['reply_note_id'] )); But the O/P is like : array 0 => array 0 => array 0 => array ...

arilia Over a year ago

edited: $r_notes = array_merge($r_notes, checkReplies( $rslt_rn[0]['reply_note_id'] )); should work without the need to add a parameter to the function

Collectives™ on Stack Overflow

Unable to create array for recursive function

2 Answers 2

3 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related