angular $http in service, return

Question

I have this in my factory

productsFactory.getOneProduct = function(){
  $http({
    method: 'GET',
    url: '/api/products/' + $stateParams.productID
  }).
    success(function(data, status, headers, config){

      console.log(data);
      return data;
    }).
    error(function(data, status, headers, config){

    });
}

This is my controller:

$scope.selectedProduct = ProductsFactory.getOneProduct();

console.log(data) outputs the data i want. But I get 'undefined' when I call it from controller. Guess it got something to do with returning from anonymous functions? Am I doing it wrong?

Christoph · Accepted Answer · 2013-09-17 14:03:15Z

2

Your getOneProduct function does not return anything which means it implicitly returns undefined, hence the error.

$http returns a promise and you must return that promise from your function. So change your code to this:

productsFactory.getOneProduct = function(){
  return $http({
    method: 'GET',
    url: '/api/products/' + $stateParams.productID
  }).
    success(function(data, status, headers, config){

      console.log(data);
      return data;
    }).
    error(function(data, status, headers, config){

    });
}

Then in your controller:

productsFactory
    .getOneProduct()
    .then(response){});

answered Sep 17, 2013 at 14:03

Christoph

28.4k33 gold badges104 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Simon · Accepted Answer · 2013-09-17 14:25:55Z

2

You need to return the Promise that is returned from $http:

productsFactory.getOneProduct = function(){
  return $http({
    method: 'GET',
    url: '/api/products/' + $stateParams.productID
  });
}

And then in your controller:

productsFactory.getOneProduct().then(successFunction, errorFunction);

You could simplify your factory call further:

 productsFactory.getOneProduct = function(){
      return $http.get('/api/products/' + $stateParams.productID);
    }

edited Sep 17, 2013 at 14:25

answered Sep 17, 2013 at 14:19

Simon

2,8312 gold badges20 silver badges24 bronze badges

2 Comments

Joe Over a year ago

Thx. But exaclty what do i type in my controller? Tried this but I get undefined. ProductsFactory.getOneProduct().then(function(d){ $scope.selectedProduct = d; });

Simon Over a year ago

What is it that is undefined? the $scope.selectedProduct? or the d?

Collectives™ on Stack Overflow

angular $http in service, return

2 Answers 2

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related