My codeigniter model is working fine in Controller but when called in view page showing error

Question

this is my controller

<?php
class Site extends CI_Controller{
    public function index(){    
    $this->load->view('home');
    }
}
?>

This is my model

<?php

class AdminModel extends CI_Model{

//function to get all the questions 

    function getAllQA(){
        $result=$this->db->get('question');
        if($result->num_rows()>0){ //this checks if the result has something if blank means query didn't get anything from the database
        return $result;
        }
        else{
        return false;
        }
    }
}
?>

and this is my view PAge

<form method="get" action="">
        <div id="container">    
            <?php
                $this->load->model('adminmodel');
                if($result=$this->adminmodel->getAllQA()){
                    foreach($result->result() as $rows){
                        echo $rows->question;
                        echo $rows->option1;
                    }
                }
                else{
                    echo "No question found";
                }
            ?>
        </div>
    </form>

So am calling the model in view called home.php page but its showing an error Call to a member function getAllQA() on a non-object in So but when am calling the model in controller its working fine but why is it showing error when am loading and calling the method in view page

why do you need to break the rules of the MVC pattern and call the model inside the view? — omma2289
– omma2289, Commented Sep 7, 2013 at 5:54
i can directly load that model in view that will be easier than to call in controller and pass it right — TaraGurung
– TaraGurung, Commented Sep 7, 2013 at 5:56

MJ X · Accepted Answer · 2013-09-08 09:56:14Z

2

Load your models inside the constructor of your controller

your controller should be like this

<?php
  class Site extends CI_Controller{
    function __construct()
    {
        parent::__construct();
        $this->load->model('adminmodel');

    }
    //if you want to pass data or records from database to view do as blow code
    public function index()
    {    
        //define an empty array
        $data = array();
        $records = $this->adminmodel-> getAllQA();

        $data['records'] = $records;

        //pass the data to view you can access your query data inside your view as $records
        $this->load->view('home',$data);
    }
  }
?>

answered Sep 8, 2013 at 9:56

MJ X

9,12413 gold badges85 silver badges124 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Freelance Developer Melbourne · Accepted Answer · 2013-09-07 06:37:33Z

1

You should not be loading Models from view files. Codeigniter is a MVC framework which means that all communication with the model should be handled by the controller.

The technical reason that this isn't working is likely that the view file is not a php class and therefore $this does not exist. Thats regardless, if you want to do something like this, don't use codeigniter!

answered Sep 7, 2013 at 6:37

Freelance Developer Melbourne

6506 silver badges13 bronze badges

1 Comment

TaraGurung Over a year ago

ok got it but my codes are inside php tags and so the model is getting multiple fields from the database how do i pass all those data from controller to my view page . I did this if($result=$this->adminmodel->getAllQA()){ foreach($result->result() as $rows){ $data['question']=$rows->question; //qustion is the array name but which will become a variable in view page } } else{ echo "No question found"; } $this->load->view('home',$data); ..how do i get all the questions that model fetches

Denis · Accepted Answer · 2013-09-07 13:58:35Z

not sure if you've done it. Usually you call your model from within the controller. In your case it would be:

    class Site extends CI_Controller{
      public function index(){    
        // load your model
        $this->load->model('adminmodel');
        // do your fancy stuff
        $data['allQA'] = $this->adminmodel->getAllQA();
        // here you can pass additional data e.g.
        $data['userdata'] = $this->adminmodel>getuserinfo();
        // pass data from controller --> view
        $this->load->view('home',$data);
      }
    }

You can access the data in your view file by acessing $allQA or $userdata respectively. E.g.

foreach ($allQA as $qa){
  echo $qa->question . "<br>" . $qa->option . "<br>";
}

or somewhere within a div

 <div class="userbadge">
   <?php echo $userdata; ?>
</div>

Collectives™ on Stack Overflow

My codeigniter model is working fine in Controller but when called in view page showing error

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related