php file upload and move to folder

Question

This is my php code

<?php
    if ($_FILES["file"]["error"] > 0)
    {
        echo "Return Code: " . $_FILES["file"]["error"] . "<br>";
    }
    else
    {
        echo "Upload: " . $_FILES["file"]["name"] . "<br>";
        echo "Type: " . $_FILES["file"]["type"] . "<br>";
        echo "Size: " . ($_FILES["file"]["size"] / 1024) . " kB<br>";
        echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br>";

        if (file_exists("upload/" . $_FILES["file"]["name"]))
        {
            echo $_FILES["file"]["name"] . " already exists. ";
        }
        else
        {
            mkdir("upload/".$title, 0700);
            move_uploaded_file($_FILES["file"]["tmp_name"],
            "upload/".$title . $_FILES["file"]["name"]);
            echo "Stored in: " ."upload/".$title . $_FILES["file"]["name"];
        }
    }
?>

Simple file upload according to W3C, however i added the mkdir to create a directory based on the title the user input.

The folder creates fine but the file won't move into it, not sure if this is something simple i thought but use the concatenate '.' i could just define the file location like i had with mkdir

The HTML is simple just input type = file and and input text type for the title

I assume where $title is defined you're parsing it to remove characters you're not allowed in a folder name? — Grim...
– Grim..., Commented Aug 22, 2013 at 15:10
thanks for the heads up, i didn't even think, i was just pulling out the users input and storing it in a variable, you have just saved me future headache, thanks again — user2389087
– user2389087, Commented Aug 22, 2013 at 15:17

Grim... · Accepted Answer · 2013-08-22 15:09:14Z

3

You need a / after $title to use the new folder.

move_uploaded_file($_FILES["file"]["tmp_name"], "upload/".$title."/".$_FILES["file"]["name"]);

answered Aug 22, 2013 at 15:09

Grim...

17k7 gold badges47 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user2389087 Over a year ago

Thanks that did it "upload/".$title.'/' .

Grim... Over a year ago

Note that your if file_exists statement needs the $title variable, too.

Amal · Accepted Answer · 2013-08-22 15:20:06Z

0

You're missing a slash in your path, as pointed out by @Grim above. I'd like to explain why:

echo "Stored in: " ."upload/".$title . $_FILES["file"]["name"];
                                  --^

Changing it to the following should fix the problem:

echo "Stored in: " ."upload/".$title . "/" . $_FILES["file"]["name"];

Your path is incorrect and move_uploaded_file will be unable to find the file in the specified path and your code won't work as you expect it to.

Without the slash, this is what your function would actually look like (assuming you define $title variable somewhere in between):

upload/fooFilename

You actually need:

upload/foo/Filename

Hope this helps!

answered Aug 22, 2013 at 15:20

Amal

76.8k18 gold badges133 silver badges154 bronze badges

1 Comment

Grim... Over a year ago

Changing the echo isn't going to fix the problem (although it will make that line more accurate). I'm constantly changing the wrong thing while displaying a query variable or something to the screen to debug it - drives me nuts!

Collectives™ on Stack Overflow

php file upload and move to folder

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related