Php: Keep same filename when downloading from server

Question

I'm downloading a file through php script and everything work perfectly except one ugly truth. The downloaded file keep the same url and with original name appended. How do I maintain the same filename when file downloaded?

http://bachday.com/index.php?page=custom&file=mmailer/download.php?mfile=sample.docx

if (isset($_GET['mfile'])) {
    $file = $_SERVER['DOCUMENT_ROOT'].'/oc-content/plugins/mmailer/pfile/'.$_GET['mfile'];

    if (file_exists($file) && is_readable($file) && preg_match('/\.docx$/',$file)) {
        header('Content-Type: application/docx');
    header("Content-Disposition: attachment; filename=\"$file\"");
    readfile($file);
    /*
    header("Expires: 0");
    header("Cache-Control: no-cache, must-revalidate");
    header("Pragma: no-cache");
    echo (readfile($file));*/


    }
    else
    {
        header("HTTP/1.0 404 Not Found");
        echo "Error 404: File Not Found: 
$file";
    }

try this code. header("Content-Disposition: attachment; filename={$name}.{$file_ending}"); the difference is in concatenating. — Dipesh Parmar
– Dipesh Parmar, Commented Aug 19, 2013 at 5:20

coderkane · Accepted Answer · 2013-08-19 05:22:56Z

3

header('Content-Disposition: attachment; filename="name_of_file_here"') would have done the trick. You are passing the full path of the file there as header("Content-Disposition: attachment; filename=\"$file\""); since your $file contains full path. Instead just send the name of the file.

answered Aug 19, 2013 at 5:22

coderkane

4985 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Apoorv Saran · Accepted Answer · 2018-01-06 11:24:31Z

1

header('Content-Disposition: attachment; filename='.basename($file));

This line can perhaps solve the issue.

answered Jan 6, 2018 at 11:24

Apoorv Saran

331 silver badge5 bronze badges

2 Comments

Sandip Ghosh Over a year ago

Please explain how can this code possibly solve the issue.

Apoorv Saran Over a year ago

.basename($file) would return the last part(the file name along with the extension) from the $file string, which is the issue asked above.

MaveRick · Accepted Answer · 2013-08-19 06:06:03Z

0

if (isset($_GET['mfile'])) {
    $file = $_SERVER['DOCUMENT_ROOT'].'/oc-content/plugins/mmailer/pfile/'.$_GET['mfile'];

    if (file_exists($file) && is_readable($file) && preg_match('/\.docx$/',$file)) {
        header('Content-Type: application/docx');
    header("Content-Disposition: attachment; filename=\"".basename($file)."\"");//use basename to extract filename from full file path
    readfile($file);
    /*
    header("Expires: 0");
    header("Cache-Control: no-cache, must-revalidate");
    header("Pragma: no-cache");
    echo (readfile($file));*/


    }
    else
    {
        header("HTTP/1.0 404 Not Found");
        echo "Error 404: File Not Found: 
$file";
    }

edited Aug 19, 2013 at 6:06

answered Aug 19, 2013 at 5:59

MaveRick

1,1896 silver badges20 bronze badges

2 Comments

cHao Over a year ago

"...filename=\"basename($file)\"" doesn't do what you think it does.

MaveRick Over a year ago

Sorry it's my mistake... forgot to keep the function out of quotations.. now you can use the original filename in the server and send it to the downloaded file

Collectives™ on Stack Overflow

Php: Keep same filename when downloading from server

3 Answers 3

Comments

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related