SqlDataReader for numeric data type

Question

I have this code:

public void nactiData()
{
        SqlCommand cm = new SqlCommand("SELECT * FROM zajezd WHERE akce="+nc_zajezd_vyber, con); 
        con.Open();
        SqlDataReader reader = cm.ExecuteReader();

        if (reader.Read())
        {
            zpocdnu.Text = reader.GetInt32(31).ToString();
            zcena3.Text = reader.GetDecimal(6).ToString();
        }

        con.Close();
    }

Problem is that it doesn't read zcena3 because the datatype in the table is numeric.

On Microsoft's website is written that I should read it with GetDecimal, but it doesn't work either.

Is there any solution?

Using * with column positions is asking for trouble. Write out the column names, like GetString("col1") — Andomar
– Andomar, Commented Jul 6, 2013 at 8:42
What exact datatype are those columns in SQL Server? If they are int, smallint or bigint; you need to use .GetInt16/.GetInt32/.GetInt64 (not .GetDecimal). You said using GetDecimal doesn't work - how does it not work? Do you get an error? If so: what error ? — marc_s
– marc_s, Commented Jul 6, 2013 at 8:51
@Andomar: it should be reader.GetString(reader.GetOrdinal("col1")) (and typically the result of calling GetOrdinal would be executed only once and then cached in a variable). — stakx - no longer contributing
– stakx - no longer contributing, Commented Jul 6, 2013 at 9:27

stakx - no longer contributing · Accepted Answer · 2013-07-06 09:25:22Z

3

(You've solved your problem yourself, but let me suggest the following.)

Since you are dealing with a SQL Server data reader, use GetSqlDecimal instead of GetDecimal:

It should perform a little better (since it doesn't do any unnecessary conversion).
It can also deal with NULL (via the IsNull property of the returned SqlDecimal value).

answered Jul 6, 2013 at 9:25

stakx - no longer contributing

85.1k20 gold badges176 silver badges277 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

SqlDataReader for numeric data type

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related