Trying to write JavaScript in PHP

Question

I can't figure out exactly how to make this work. I am new to PHP by the way.

Here is what I current have (zerkms's solution), and it still isn't working for some strange reason:

here is a link to the page on the server:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Demo</title>
<?php



$srcmsg = 'http://www.newyorker.com/online/blogs/photobooth/NASAEarth-01.jpg';
?>
<script type="text/javascript">
//<![CDATA[
//

var msr = "<?php echo $srcmsg; ?>";

window.onload = document.getElementsByTagName('img').src= msr;
//]]>
</script>
</head>
<body>
<img src="#" alt="Picture of the world" height="42" width="42" />
</body>
</html>

yes. I used firebug. it doesn't say anything except the usual error which is : The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol. — user1066524
– user1066524, Commented Jun 10, 2013 at 21:39
if you are asking about CDATA, that is just what you can use to make sure that all data inside the CDATA will be ignored by XML parser. just a style choice really. — user1066524
– user1066524, Commented Jun 10, 2013 at 21:43
@user1066524 Most probably. I don't have enough experience with JSON, but enough to say yes. I suggest you ask another question with what you mentioned to me earlier, outlining your actual plan. I'm sure you'll get a good response if it's well outlined. — Funk Forty Niner
– Funk Forty Niner, Commented Jun 11, 2013 at 0:11

Niet the Dark Absol · Accepted Answer · 2013-06-10 22:07:19Z

1

This has nothing to do with the PHP part.

This is not working purely because you are attempting to change an image that doesn't exist yet.

Either move your script to the end of the <body> (right before the </body> tag), or use window.onload = function() { /* your code here */ }, or implement some kind of deferring system.

answered Jun 10, 2013 at 22:07

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

user1066524 Over a year ago

I tried window.onload = function(){ document.getElementsByTagName('img').src= msr;}; and it still doesn't work.

Niet the Dark Absol Over a year ago

That would be because getElementsByTagName returns elementS. Plural. It'd be better to put an ID on it and use getElementById, but if you can't do that then try getElementsByTagName('img')[0].

user1066524 Over a year ago

this the error I get when I try this: TypeError: document.getElementsByTagName('img')[0] is undefined

Niet the Dark Absol Over a year ago

Did you combine it with one of the three solution I gave you in the answer?

user1066524 Over a year ago

Yes, I tried combining it with your solutions. Wouldn't you only use the [0] if it was a child element within the element? I thought [0] refers to the index of the first child in Javascript--this has no children. But thanks for your help Kolink.

|

Collectives™ on Stack Overflow

Trying to write JavaScript in PHP

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related