PHP Update MySQL DB with AJAX call isn't doing anything

Question

I'm trying to update a field on my database with PHP and AJAX

I have tested and found that the correct data is being sent, but the PHP that is handling the update is not working correctly.

All that happens is that I get the else response in conditional.

I need to update the DB depending on what the user input is.

Like I said, all I get for the response is the else response.

$youruname = $_POST['youruname'];
$selectedplayer = $_POST['selectedplayer'];
$selPlayerUname = $_POST['selPlayerUname'];

$flag = "";
$itStatus = "";

$checkit = mysqli_query($conn,"SELECT it FROM login WHERE uname='$selPlayerUname'");

while($row = mysqli_fetch_array($checkit))
{
    $itStatus = $row["it"];
}

if($itStatus == "not it")
{
    mysqli_query("UPDATE login SET it = CASE WHEN uname = '$youruname' THEN 'not it' ELSE 'it' END WHERE uname IN ('$youruname', '$selPlayerUname')");

    $flag = "success";
}
else if($itStatus == "it")
{
    $flag = "nope";
}
else
{
    $flag = "error";
}
echo json_encode(array("message" => $flag, "tagged" => $selectedplayer));

mysqli_free_result($checkit);
mysqli_close($conn);

Warning: your queries are vulnerable to SQL injection. Please switch to prepared statements. — Marcel Korpel
– Marcel Korpel, Commented Jun 4, 2013 at 14:54
On your update query you have 'SET it = CASE' if CASE is a column there is no problem, but, if is not? Also, your code is vulnerable to sql injection. Learn how to use prepared statements. — Luigi Siri
– Luigi Siri, Commented Jun 4, 2013 at 14:56
I'm going to switch to prepared statements once I get it working. I've gotten that a lot about injection. I know I need to, but am just fixing one problem at a time. Thank you for the concern, though — copilot0910
– copilot0910, Commented Jun 4, 2013 at 14:57
One other thing, Add to your queries an error output... you can use ...or die(mysqli_error()); for example. It will tell you what's your query issue. And Please, Don't let security flaws for last. — Luigi Siri
– Luigi Siri, Commented Jun 4, 2013 at 15:00

GGio · Accepted Answer · 2013-06-04 15:10:26Z

1

There is something confusing here. You have a loop and after loop conditionals. Shouldnt your update query be inside a loop like:

while($row = mysqli_fetch_array($checkit))
{
    $itStatus = $row["it"];


    if($itStatus == "not it")
    {
       mysqli_query("UPDATE login SET it = CASE WHEN uname = '$youruname' THEN 'not  it' ELSE 'it' END WHERE uname IN ('$youruname', '$selPlayerUname')");

       $flag = "success";
    }
    else if($itStatus == "it")
    {
       $flag = "nope";
    }
    else
    {
       $flag = "error";
    }
}

Your $iStatus gets the last value from the database since its in the loop and then you check in conditionals

If above does not help then check your $_POST values to see if any of them are blank or null and do the query on PHPMyAdmin see if it actually returns anything.

edited Jun 4, 2013 at 15:10

answered Jun 4, 2013 at 14:48

GGio

7,67311 gold badges48 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

copilot0910 Over a year ago

I needed to pass the connection to the mysqli_query as well. I wasn't doing that. But, you raised a great point about the loop and where to put the query for updating. So for that, I thank you.

copilot0910 · Accepted Answer · 2013-06-04 15:10:45Z

0

mysqli_query requires you to pass the connection.

I wasn't doin that.

When I passed the values to the query directly, I figured it out.

Thank you very much for the help everyone

answered Jun 4, 2013 at 15:10

copilot0910

4312 gold badges6 silver badges19 bronze badges

Collectives™ on Stack Overflow

PHP Update MySQL DB with AJAX call isn't doing anything

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related