How to Declare a List<> of Enums in C#

Question

I need to declare a List of Enums and I can't figure out how to do it right.

This is my code so far:

public enum Languages
{
    Ger,Eng,Fra,Ita,Rus
}

public class Player
{
    public string ID { get; private set; }
    private List<Languages> Languages;

    public Player(string ID, List<Languages> LangList)
    {
        this.ID = ID;
        this.Languages = LangList;
    }
}

class Program
{
    static void Main(string[] args)
    {
        Player PlayerA = new Player("Player A", **[Problem is here]**);
    }
}

As you can see the constructor of Player expects a list of languages that are supported by the player. I wanted to define the possible Languages as enums. Now i don't know how i declare such a list in the construction call.

I know i could just do it like this:

        List<FoolMeLib.Languages> pLang = new List<FoolMeLib.Languages>;
        pLang.Add(FoolMeLib.Languages.Ger);
        pLang.Add(FoolMeLib.Languages.Eng);
        NewGame.AddPlayer(new FoolMeLib.Player("Player A", pLang));

but i want to write the code as sleek as possible... Btw: if you see any other bad practice: tell me. I'm triing to improve.

http://stackoverflow.com/questions/1167361/how-do-i-convert-an-enum-to-a-list-in-c — T I
– T I, Commented Jun 1, 2013 at 22:51
Try public Player(string ID, IEnumerable<Languages> LangList) and pass an array with new[] { Language.Ger, Language.Eng }. — John Alexiou
– John Alexiou, Commented Jun 2, 2013 at 0:14

Marc Gravell · Accepted Answer · 2013-06-01 22:52:34Z

12

Without code changes to Player, you could do:

NewGame.AddPlayer(new FoolMeLib.Player("Player A",
    new List<FoolMeLib.Language> {
        FoolMeLib.Languages.Ger, FoolMeLib.Languages.Eng
}));

If you ware open to changes, a params FoolMeLib.Languages[] languages parameter would allow:

NewGame.AddPlayer(new FoolMeLib.Player("Player A",
    FoolMeLib.Languages.Ger, FoolMeLib.Languages.Eng));

Or if you allow the enum to be a [Flags] - just one parameter is needed:

NewGame.AddPlayer(new FoolMeLib.Player("Player A",
    FoolMeLib.Languages.Ger | FoolMeLib.Languages.Eng));

(But they would need specific numbers in the 2ⁿ range)

answered Jun 1, 2013 at 22:52

Marc Gravell

1.1m273 gold badges2.6k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jods · Accepted Answer · 2013-06-01 22:59:37Z

2

Good options for collection initializer have been posted.

Another options could be to use flags:

[Flags]
public enum Languages { Ger = 1,Eng = 2,Fra = 4,Ita = 8, Rus = 16 }

// ctor
public Player(string id, Languages languages) {}

// call
new Player("Player A", Languages.Eng | Languages.Fra);

Depending on what you plan to do with the languages this might be a good or a bad design.

answered Jun 1, 2013 at 22:59

jods

4,59118 silver badges20 bronze badges

Comments

Dave Hillier · Accepted Answer · 2013-06-01 22:55:37Z

1

I think your title and question are misleading, you might actually be looking for params.

For example if you redefine you constructor like:

public Player(string ID, params Languages[] languages)
{
   Languages = languages.ToList();
}

You can pass the languages you support as a list of parameters

new Player("Player A", Languages.Ger, Languages.Eng)

answered Jun 1, 2013 at 22:55

Dave Hillier

19.2k10 gold badges46 silver badges91 bronze badges

Comments

Ron.B.I · Accepted Answer · 2013-06-01 22:51:22Z

0

Enum.GetValues(typeof(Languages)).Cast<Languages>();

answered Jun 1, 2013 at 22:51

Ron.B.I

2,7861 gold badge22 silver badges28 bronze badges

1 Comment

Tim Schmelter Over a year ago

He doesn't want all languages.

Fabian Bigler · Accepted Answer · 2013-06-01 22:56:44Z

0

Your question:

How to call the constructor with the list of languages?

The sleekest possible way:

E.g. you have a player who can speak english and german:

Player PlayerA = new Player("Player A", new List<Languages> 
{ Languages.Eng, Languages.Ger });

answered Jun 1, 2013 at 22:56

Fabian Bigler

10.9k6 gold badges52 silver badges74 bronze badges

Comments

lightbricko · Accepted Answer · 2013-06-01 23:01:58Z

0

If you do not accept to modify class Player, just call the constructor like this:

new Player("Player A", new List<Languages> { Languages.Ger, Languages.Eng });

If you do accept to modify class Player, use params and change type of Languages to Languages[]:

public enum Languages
{
    Ger, Eng, Fra, Ita, Rus
}

public class Player
{
    public string ID { get; private set; }
    private Languages[] Languages;

    public Player(string ID, params Languages[] LangList)
    {
        this.ID = ID;
        this.Languages = LangList;
    }
}

class Program
{
    static void Main(string[] args)
    {
        Player PlayerA = new Player("Player A", Languages.Ger, Languages.Eng);
    }
}

edited Jun 1, 2013 at 23:01

answered Jun 1, 2013 at 22:56

lightbricko

2,70918 silver badges22 bronze badges

Collectives™ on Stack Overflow

How to Declare a List<> of Enums in C#

6 Answers 6

Comments

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related