Foreach while loop php issue

Question

I'm trying to display only the names that are not empty from this array on a new line for each. Currently, using this, it is only displaying "$playerName1"'s name 10 times. I'm trying to figure out why it's not actually looping through all 10 playerName's. It seems to only be checking $playerName1.

$z = array($playerName1, $playerName2, $playerName3, $playerName4, $playerName5, $playerName6, $playerName7, $playerName8, $playerName9, $playerName10);
$zCounter = 1;
foreach ($z as $allNames) {
  while ($allNames != "" && $zCounter < 11) {
    echo $allNames . "<br>";
    $zCounter++;
  }
}

On an issue unrelated to the question, but showing up in your code, consider using !empty($allNames). — Orbling
– Orbling, Commented May 31, 2013 at 18:56

grandivory · Accepted Answer · 2013-05-31 18:52:39Z

4

Your problem is that you are going through the inner while loop for only the first player name. The outer foreach loop should be plenty:

foreach ($z as $playerName) {
  if ("" !== $playerName) {
    echo $playerName . "<br />";
  }
}

answered May 31, 2013 at 18:52

grandivory

6393 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Samuel Cook · Accepted Answer · 2013-05-31 18:52:56Z

2

Unless you want to output each name 10 times, remove the while loop. You can still check to make sure the name is not empty by using !='' or empty()

<?php
$z = array($playerName1, $playerName2, $playerName3, $playerName4, $playerName5, $playerName6, $playerName7, $playerName8, $playerName9, $playerName10);
foreach($z as $name){
    if(!empty($name)){
        echo $name.'<br>';
    }
}

answered May 31, 2013 at 18:52

Samuel Cook

16.9k7 gold badges56 silver badges65 bronze badges

Comments

Patrick Evans · Accepted Answer · 2013-05-31 18:51:39Z

1

you need to reset the $zCounter after each while loop

foreach ($z as $allNames) {
  while ($allNames != "" && $zCounter < 11) {
    echo $allNames . "<br>";
    $zCounter++;
  }
  $zCounter = 0;
}

otherwise after the first while loop finishes, $zCounter will always be 11

answered May 31, 2013 at 18:51

Patrick Evans

42.8k6 gold badges81 silver badges94 bronze badges

1 Comment

Patrick Evans Over a year ago

Why the downvote this perfectly fixes his problem. He didnt say anything about not wanting them each displayed 10 times.

Collectives™ on Stack Overflow

Foreach while loop php issue

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related