Numeric PHP validation?

Question

I have some code written in php to validate a postcode field in my form. The code is meant to check that the field is not empty (mandatory) and matches one of 5 usable postcodes, if not it displays an alert. The problem i am having is that when i leave the field empty and hit the submit button the proper alert is show but if i enter a wrong value and hit submit the form just loads to a blank screen, can anyone spot a mistake in my code? :

 <?php

 if (isset($_POST['submit'])) {

$post = $_POST["post"];
$words = array('2747','2750','2753','2760','2777');
$msgp = "";

if (!empty($post)) {
foreach ($words as $item)
{
    if (strpos($post, $item) !== false)
        return true;
}
$msgp = '<span class="error"><b>Please enter correct postcode</b></span>';
return false;

} else if(empty($post)) {
$msgp = '<span class="error"><b>Please enter postcode</b></span>';
}

}

?>

<form name="eoiform" method="POST" action="<?php echo $_SERVER["PHP_SELF"];?>" id="eoi">

<b>Post Code</b>
<br>
<input type="text" id="post" name="post" /><?php echo $msgp; ?>

</form>

Why not just use a <select> element with only those 5 values? — leftclickben
– leftclickben, Commented May 31, 2013 at 10:52
i've answered your question. Select is better option but there should always be validation too. — Robert
– Robert, Commented May 31, 2013 at 10:58

bwoebi · Accepted Answer · 2013-05-31 10:50:53Z

3

return? Return where?

When you return in your main code, it's (nearly) the same as die()'ing.

So when you return, the remaining PHP won't be executed anymore.

I'd consider to set some variable like $success = true/false; instead of returning.

answered May 31, 2013 at 10:50

bwoebi

23.8k5 gold badges64 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Salketer · Accepted Answer · 2013-05-31 10:50:32Z

2

You return false after $msgp = '<span class="error"><b>Please enter correct postcode</b></span>'; therefor you do not continue to the form below... remove the returns from your code to be able to handle and show an error.

answered May 31, 2013 at 10:50

Salketer

15.8k2 gold badges32 silver badges64 bronze badges

1 Comment

AJJ Over a year ago

ah i see, i took out the returns and just left the messages and now it works just fine, thank you!

nl-x · Accepted Answer · 2013-05-31 10:51:09Z

1

You are using return. Are you in a function() {} ? If so, all your variables are in function scope. You could do global $msgp; to make the variable accessible outside of the function.

If not... then you shouldn't use return.

answered May 31, 2013 at 10:51

nl-x

11.9k7 gold badges36 silver badges67 bronze badges

1 Comment

leftclickben Over a year ago

I still give this +1 even though I disagree with the idea of using globals. If you are in a function you could return $msgp or pass it as a parameter by reference.

Community · Accepted Answer · 2023-11-17 20:13:27Z

0

Change php code to

<?php

if (isset($_POST['post'])) {
$post = intval($_POST["post"],0);
$words = array(2747,2750,2756,2760,2777);
$msgp = '<span class="error"><b>'.in_array($post,$words) ? "Please enter postcode" : "Please enter correct postcode" .'</b></span>';
}

There are a lot of things that can be simplified. For example codes as int array and using in_array() function. Return statement should be used to return something from method/function using it in global scope then execution of the current script file is ended. There is no need for it here. If there are more $words values you should consider using simple REGEX /[0-9]{4}/ and preg_match()

edited Nov 17, 2023 at 20:13

CommunityBot

11 silver badge

answered May 31, 2013 at 10:55

Robert

20.3k6 gold badges58 silver badges85 bronze badges

Comments

Bere · Accepted Answer · 2013-05-31 11:06:49Z

0

You want to display $msgp right? Use echo $msgp;. But you can return to nowhere in your code. (put it in a function).

Try this

<?php        
$post = $_POST["post"];
$words = array('2747','2750','2753','2760','2777');
$msgp = "<span class='error'><b>Please enter correct postcode</b></span>";
function check($post){
  global $words;
  $return=true;
  if (!empty($post)) {
      foreach ($words as $item)
      {
          if (strpos($post, $item) !== false)
              //$return=true;
      }

  } else if(empty($post)) {
      $return=false;
  } 
  return $result;
}

$return=check($post);
if($return === true){
// echo you are right!
}
else {
    echo $msgp;
}

edited May 31, 2013 at 11:06

answered May 31, 2013 at 11:00

Bere

1,7472 gold badges17 silver badges23 bronze badges

Collectives™ on Stack Overflow

Numeric PHP validation?

5 Answers 5

Comments

1 Comment

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related