Extract list of objects from a string using linq

Question

I'm new to linq. I have a string having the following format

code:description;code2:description2;code3:description3... etc.

Records are separated with ; character and each record has 2 fields separated with : character.

I'm writing a linq query to extract a list of objects having as fields code and description. I have written the following query which seems to produce correct results, but I was wondering if there is a better or more correct way to do it.

var objects =
    from objString in recsString.Split(';')
    let obj = objString.Split(':')
    select new {
        Code = obj[0].Trim(),
        Description = obj[1].Trim()
    };

Is your "object" defined as its own class somewhere in your project. If so, you could call a constructor in your select statement. IE - select new Record(code, description); — WEFX
– WEFX, Commented May 22, 2013 at 14:25
No it's anonymous, I will create a class if I see I need it, but for now it's enough. — alfoks
– alfoks, Commented May 22, 2013 at 14:25
This will not work if you have : or ; in code or description, or if any entry is empty or half-empty. Other than that its fine. — David S.
– David S., Commented May 22, 2013 at 14:28

Mathew Thompson · Accepted Answer · 2013-05-22 14:24:12Z

6

That's perfectly fine, the only observation I would make though is that you remove empty entries by using the StringSplitOptions:

var objects =
from objString in recsString.Split(';', StringSplitOptions.RemoveEmptyEntries)
let obj = objString.Split(':', StringSplitOptions.RemoveEmptyEntries)
select new {
    Code = obj[0].Trim(),
    Description = obj[1].Trim()
};

If you think that there could be missing information, you could also be extra safe and null check the results:

var objects =
from objString in recsString.Split(';', StringSplitOptions.RemoveEmptyEntries)
let obj = objString.Split(':', StringSplitOptions.RemoveEmptyEntries)
select new {
    Code = obj.Any() ? obj[0].Trim() : string.Empty,
    Description = obj.Count > 1 ? obj[1].Trim() : string.Empty
};

answered May 22, 2013 at 14:24

Mathew Thompson

56.5k15 gold badges131 silver badges151 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

alfoks Over a year ago

Ok then! Thanks for the extra recommendations.

Dimitar Dimitrov · Accepted Answer · 2013-05-22 14:34:22Z

3

What you're doing is just fine, here is how you'd write it using lambdas:

string objString = "code:description;code2:description2;code3:description3";

Dictionary<string, string> results =
    objString.Split(';')
             .Select(x => x.Split(':'))
             .ToDictionary(key => key[0], value => value[1]);

// And now you have a nice little dictionary
foreach (var r in results)
    Console.WriteLine("{0}:{1}",r.Key, r.Value);

Or of course:

    var results = objString.Split(';')
                           .Select(x => x.Split(':'))
                           .Select(x => new {Code = x[0], Description = x[1]});

    foreach (var r in results)
        Console.WriteLine("{0}:{1}",r.Code, r.Description);

edited May 22, 2013 at 14:34

answered May 22, 2013 at 14:28

Dimitar Dimitrov

15.2k9 gold badges55 silver badges82 bronze badges

2 Comments

alfoks Over a year ago

Nice approach. Objects list suits better my needs for now.

Dimitar Dimitrov Over a year ago

Sure, I though a different prospective might be useful :)

Collectives™ on Stack Overflow

Extract list of objects from a string using linq

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related