Having issues with a replace function in Javascript

Question

Okay, so I have some variables in javascript...

var link = 'http://8wayrun.com/streams/multi?type=3&pos1=1.teamsp00ky.video&pos2=1.teamsp00ky.chat&pos3=1.nycfurby.chat';
var position = 2;

As you can see, I have a link and a position. Using the position var I would like to replace some text in the link field. I would like to strip &pos2=1.teamsp00ky.chat from the link. Naturally, I have to do some basic regular expressions; the problem comes into when I try to use the position var in the regex. I just can't figure it out.

In PHP I could do the following:

preg_replace('/&pos'.$position.'=[^&]*/i', '', $link);

I tried the following in JS, but its not working:

link.replace(new RegExp('&pos'+position+'=[^&]*'), '');

Could someone help me out and tell me what I'm doing wrong? Also, how would I make it case-insensitive?

In fact, in PHP preg_replace doesn't modify $link either. You still have to do the assignment. — Martin Ender
– Martin Ender, Commented Apr 20, 2013 at 20:18

Ian · Accepted Answer · 2013-04-20 20:08:27Z

5

You need to set the value, not just call the method:

link = link.replace(new RegExp('&pos'+position+'=[^&]*'), '');

To make it case insensitive, use this regex:

new RegExp('&pos'+position+'=[^&]*', "i")

Although it might make it easier if you split the string on the "?", then split up the key/value pairs by "&", and then split them by "=".

edited Apr 20, 2013 at 20:08

answered Apr 20, 2013 at 19:59

Ian

51k13 gold badges104 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ian Over a year ago

@JasonAxelrod Haha no problem, it's just different in Javascript.

Bergi · Accepted Answer · 2013-04-20 20:01:27Z

2

Could someone help me out and tell me what I'm doing wrong?

replace does not mutate the string, but returns a new one - you'd have to assign it somewhere.

Also, how would I make it case-insensitive?

Pass the i flag to the RegExp constructor.

link = link.replace(new RegExp('&pos'+position+'=[^&]*', 'i'), '');

answered Apr 20, 2013 at 20:01

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Comments

Xotic750 · Accepted Answer · 2013-04-20 20:05:50Z

0

<div id="result"></div>

var link = 'http://8wayrun.com/streams/multi?type=3&pos1=1.teamsp00ky.video&pos2=1.teamsp00ky.chat&pos3=1.nycfurby.chat';
var position = 2;

var start = link.indexOf("pos2");

var end = link.indexOf("&", start);

document.getElementById("result").textContent = link.slice(0, start) + link.slice(end + 1);

on jsfiddle

answered Apr 20, 2013 at 20:05

Xotic750

23.6k8 gold badges59 silver badges81 bronze badges

Collectives™ on Stack Overflow

Having issues with a replace function in Javascript

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related