Passing object array - Unexpected token [

Question

function showConfirm(reArray) {

    var theHTML = '';
    var optionArray = ["Option 1", "Option 2", "Option 3", "Option 4", "Option 5", "Option 6", "Option 7"]; 
    var myButtons = {};
    var j = 1;

    for(var i = 0; i < reArray.length; i++){

                theHTML  +='<div style="text-align:center">' 
                         + '<span>'+j+'.</span>&nbsp;&nbsp;&nbsp;&nbsp;'
                         + '<span>'+reArray[i].RoadNo+'</span>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;'
                         + '<span>'+compass_image(reArray[i].Bearing)+'</span>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;'
                         + '</div><br/>'    

                j++;
        }

    for(i = 0; i < reArray.length; i++){

    ERROR HERE -----> var placeFunction = function(reArray[i]){

                                plotRoadInfo(reArray[i]);
                                $(this).dialog("close");
                            };

                            myButtons[optionArray[i]] = placeFunction;
    }

    $( "#dialog-modal" ).dialog({
      height: 300,
      modal: true,
      buttons: myButtons

    });

    $('#multipleRE').append(theHTML);
}

So the function gets passed an object array (reArray), it then creates an array of buttons (myButtons) for a jquery dialog box. I'm attempting to to pass reArray[i] to the function that will be used by each button, which is to execute plotRoadInfo(reArray[i]);

I keep getting "Unexpected token [", and I can't figure out why for the life of me.

You're function clause is a function instantiation. It doesn't make sense for a formal parameter to have an index expression like that. — Pointy
– Pointy, Commented Apr 15, 2013 at 1:34

Community · Accepted Answer · 2017-05-23 12:18:55Z

3

You don't specify the type of a parameter in JavaScript, simply use the name and then use it as an array in your function.

var placeFunction = function(reArray){
    plotRoadInfo(reArray[i]);
    $(this).dialog("close");
};

I don't think you even need to specify it though as you're referring to as array that the inner function has access to.

var placeFunction = function() {
    plotRoadInfo(reArray[i]);
    $(this).dialog("close");
};

As Pointy notes this will run in to issues with the i variable being shared so each function will refer to reArray[reArray.length] because the loop will complete when i === reArray.length. A common way to get around this is to call a function that accepts i as a parameter that will return a function.

var placeFunction = (function (item) {
    return function() {
        plotRoadInfo(item);
        $(this).dialog("close");
    };
}(reArray[i]));

Read up on closures for a deeper understanding of how this works. Here is another example of this happening.

edited May 23, 2017 at 12:18

CommunityBot

11 silver badge

answered Apr 15, 2013 at 1:34

Daniel Imms

50.6k19 gold badges157 silver badges170 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Pointy Over a year ago

This probably won't work, however, because "i" in the external context is shared among all the "placeFunction" instances.

Matthew Paxman Over a year ago

Thanks for the quick response. I'll try your first suggestion now. I've tried the second suggestion (no specification) and none of the objects properties were passing to plotRoadInfo(). Lemme get on the other option now and I'll get back to you.

Matthew Paxman Over a year ago

Ok so, @DanielImms, passing function(reArray) gets rid of the error, but none of the object properties pass. For example, in plotRoadInfo();: reArray.Lat now comes up with the error Cannot read property 'Lat' of undefined.

Daniel Imms Over a year ago

I updated my answer, it's undefined because its referring to reArray[reArray.length].

Matthew Paxman Over a year ago

Should I just pass plotRoadInfo(reArray) instead of passing [i], or do I still need to specify that I'm passing the [i]th object?

|

Kenneth · Accepted Answer · 2013-04-15 01:38:14Z

2

The syntax you have is incorrect.

I believe what you want to do is the following:

var placeFunction = 
    (function(arrayitem){
        return function(){
                   plotRoadInfo(arrayitem);
                   $(this).dialog("close");
               };

     })(reArray[i]);

myButtons[optionArray[i]] = placeFunction;

answered Apr 15, 2013 at 1:38

Kenneth

28.8k7 gold badges65 silver badges85 bronze badges

Comments

Joseph · Accepted Answer · 2013-04-15 01:33:48Z

1

Why does the parameter have an index?

function(reArray[i])

did you mean

function(reArray)

answered Apr 15, 2013 at 1:33

Joseph

120k31 gold badges186 silver badges238 bronze badges

Collectives™ on Stack Overflow

Passing object array - Unexpected token [

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related