Think this is a chicken-or-egg or closure problem or something else I'm missing. How do I loop through numerical selector values in JQuery when there is an onClick event handler?
$("#q01").click(function() {
clearIt();
$("#item01").show();
});
$("#q02").click(function() {
clearIt();
$("#item02").show();
});
$("#q03").click(function() {
clearIt();
$("#item03").show();
});
You might want to try this:
$("[id^=q]").each(function () {
$(this).click(function () {
clearIt();
var id = this.id.replace(/[^\d]/g, '');
$("#item" + id).show();
});
});
[^\d.] instead of [^\d]?It's hard to say exactly, since your example is probably simplified. But try a more general selector, rather than selecting them by ID (you can use $('[id^="q"]'), but that's not really best practice). You're using the ID element like a class, which isn't really what id is for.
If you give them all a class attribute like class="q" for the buttons and class="item" for the targets, you can do something like this:
$('.q').each(function(index) {
var targetItem = $('.item').eq(index);
$(this).click(function() {
clearIt();
targetItem.show();
});
});
But it'll be easier, safer, and better practice to specify the target of each clickable element right there in the markup:
<a href="#" class="p" target-index="01">p01</a>
<a href="#" class="p" target-index="02">p02</a>
<div class="item" item-index="01">item01</div>
<div class="item" item-index="02">item02</div>
Then their order and location on the page won't matter. You can just select them directly:
var num = $(this).attr('target-index');
var targetItem = $('.item[item-index="' + num + '"]');
Finally (and my preferred advice), you can put the ID of the target right into the button itself:
<a href="#" class="p" for="item01">p01</a>
<div id="item01">item01</div>
Then you can select the target quickly, safely, and regardless of its location:
var targetItem = $('#' + $(this).attr('for'));
Edit 1:
My first snippet makes assumptions about the order of your elements, because there are lots of ways for the clicked element to be associated with the target item. Only you know the rules for your markup, so only you know what assumptions will work. For example:
var targetItem = $('#' + $(this).attr('id').replace(/^q/, 'item'));
var targetItem = $(this).siblings('[id^="item"]');
var targetItem = $(this).children('[id^="item"]');
var targetItem = $(this).parents('[id^="item"]');
var targetItem = $(this).find('[id^="item"]');
If you don't use the target-index technique I suggested, you'll have to make at least some assumptions based on your knowledge of the HTML.
Edit 2:
Based on your comment that you're trying to trigger the handlers, rather than improve your event-binding code, you can do that like this:
//quick and dirty zero-padding function from http://stackoverflow.com/q/10073699/399649
var pad = function(num, size) {
return (Math.pow(10, size) + ~~num).toString().substring(1);
};
for(var i = 1; i < $('[id^="q"]').length; i++) {
var index = pad(i, 2);
$('#q' + index).trigger('click');
}
+1 For providing the best-practice solution :)You can utilize jquery starts with selector. While using a starts with selector it always advised to use a context within the elements reside. But you can also use a class name for the buttons and bind it with click event with single selector.
$('[id^=q]','çontext').click(function(){...}
or
$('input.classSelector',context).click(function(){...})
function clearIt()
{
$('[id^=item]','#section').hide();
}
clearIt();
$('[id^=q]','#section').click(function(){
clearIt();
$('#item' + $(this).attr('id').replace('q',''),'#section').show();
});
<div id="section">
<input id="q01" type="button" class="itemBtn" value="q1"/>
<input id="q02" type="button" class="itemBtn" value="q2"/>
<input id="q03" type="button" class="itemBtn" value="q3"/>
<div id="item01" class="itemDiv">test</div>
<div id="item02" class="itemDiv">test2</div>
<div id="item03" class="itemDiv">test3</div>
</div>
function clearIt()
{
$('.itemDiv','#section').hide();
}
clearIt();
$('.itemBtn','#section').click(function(){
clearIt();
$('.itemDiv:nth-of-type(' + parseInt($(this).attr('id').replace('q','')) + ')','#section').show();
});
<button id="queueItem" /> or some other element with an id starting with q?
You can use jquery each():
$('[id^=q0]').each(function (i) {
++i;
$(this).click(function () {
$('#item0' + i).show();
});
});
<div id="q03">Click</div> is present before <div id="q01">Click</div>?index isn't robust var items= $('.item');
$('.btn').click(function(){
var num = $(this).attr('id').match(/\d+/ig)
var item = $('#item'+num[0]+'.item');
if(item.length){
clearIt();
item.show();
}
})
function clearIt(){
items.hide();
}
<a id="q01" href="#" class="btn">Q01</a>
<a id="q02" href="#" class="btn">Q02</a>
<a id="q03" href="#" class="btn">Q03</a>
<div id="item01" class="item">Item 01</div>
<div id="item02" class="item">Item 02</div>
<div id="item03" class="item">Item 03</div>
This way you could add and remove the show/hide toggling by simply removing the class .btn or .item.
You should try data- attributes. In this way, you don't need any string replacement. Just keep the target's id in a data attribute, in this example I use data-target. You can change to any name you like. data-show
, data-blah.
HTML
<button type="button" class="clear-it" data-target="item01">Clear it and
show the target</button>
JavaScript
$('.clear-it').each(function() {
clearIt();
$(this).click(function() {
var whereToGo = this.getAttribute('data-target');
// or var whereToGo = this.dataset.target;
// or var whereToGo = $(this).data('target');
$("#" + whereToGo).show();
});
})
