VBA Nested On Error GoTo

Question

I have VBA code that is supposed to be nested error checking, but it does not. The code is psuedo as below. However, whenever an error occurs within an error (For instance, an error is tripped in the loop, goto SmallError occurs, and an error occurs in SmallError) The second GoTo is not used. The error then breaks the code.

Ex:

Error in Loop

GoTo SmallError

Error in SmallError

Code Breaks (Here code should GoTo FatalError)

Sub DoThings()
    On Error GoTo SmallError
    'Coding Happens
    Do While(conditionhere)
       'Looping things happen
    GoTo LoopResume
SmallError:
    source = Err.source
    descript = Err.Description
    On Error GoTo Fatal Error
    'Small error processing happens
    Resume LoopResume
FatalError:
    source = Err.source
    descript = Err. Description
    On Error GoTo ExitError
    'Fatal Error processing happens
ExitError:
    Exit Sub
LoopResume:
count = count + 1 
Loop

On Error GoTo FatalError
'Finishing code happens
End Sub

Community · Accepted Answer · 2018-05-08 21:48:18Z

4

You can't use an On Error statement within an error handler. See e.g. this article that explains this.

What you CAN do however is to have a separate routine that handles the "regular error". This routine can have a "fatal error" handler. Your code would then look something like this:

(Edit: Edited the code to enable exit when there is a fatal error):

Sub DoThings()
On Error GoTo SmallError
    Dim fatalExit As Boolean
    'Coding Happens
    Do While(conditionhere)
       'Looping things happen
LoopResume:
       count = count + 1 
    Loop
On Error Goto SmallError2
'Finishing code happens
  Exit Sub
SmallError:
    handleError Err.Source, Err.Description, fatalExit
    If fatalExit Then 
       Exit Sub
    Else
      Resume LoopResume
    End If
SmallError2:
    handleError Err.Source, Err.Description, fatalExit
    Exit Sub
End Sub

Private Sub handleError(ByVal source As String,ByVal description As String, ByRef fatalExit As Boolean)
On Error Goto FatalError
  'Do "small error" handling here
   Exit Sub
FatalError:
  fatalExit = True
  'Do "fatal error" handling here
End Sub

edited May 8, 2018 at 21:48

CommunityBot

11 silver badge

answered Apr 4, 2013 at 13:32

GTG

4,9542 gold badges25 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

steventnorris Over a year ago

In this case, the fatal error wouldn't exit the sub though. It would exit handleError, but continue with DoThings. I need a way to back out of the DoThings sub on fatal error.

John Bustos · Accepted Answer · 2013-04-04 13:15:45Z

0

... you have Fatal Error in your Goto rather than FatalError, that won't get you to the right location...

Update your code to:

On Error GoTo FatalError

answered Apr 4, 2013 at 13:15

John Bustos

19.7k18 gold badges102 silver badges162 bronze badges

1 Comment

steventnorris Over a year ago

That was just a typo. apologies.

Collectives™ on Stack Overflow

VBA Nested On Error GoTo

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related