PHP/MySQL - while loop only showing latest entered record

Question

I am attempting to have a while loop display all records selected from table, and iterate the results encapsulated in a < div >. My query is working, and the while is displaying something...but only the latest record. I can't figure out why this is, and I'm very new to PHP so any assistance would be great.

Code:

<?php
//Connect to database and select table
$conn = mysql_connect("", "", "") or die(mysql_error());
mysql_select_db("substest", $conn) or die(mysql_error());
//Issue query
$get_features = "SELECT ID, Title, DateReceived, Synopsis FROM features ORDER BY ID";
$r_get_features = mysql_query($get_features) or die(mysql_error);

if(mysql_num_rows($r_get_features) < 1)  {
    $display_block = "<div class=\"inner\"><h2>Nothing to display</h2></div>";
}
else {
    while($feat_array = mysql_fetch_array($r_get_features)) {
    $feat_id = $feat_array["ID"];
    $feat_title = stripslashes($feat_array["Title"]);
    $feat_dater = stripslashes($feat_array["DateReceived"]);
    $feat_synopsis = stripslashes($feat_array["Synopsis"]);

    $display_block = "<div class=\"inner\">";
    $display_block .= "<h2>".$feat_title."</h2>";
    $display_block .= "<label for \"id\">ID:</label>";
    $display_block .= "<span class=\"formresult\" id=\"id\">".$feat_id."</span><br />";
    $display_block .= "<label for=\"title\">Title:</label>";
    $display_block .= "<span class=\"formresult\" id=\"title\">".$feat_title."</span><br />";
    $display_block .= "<label for=\"datereceived\">Date Received:</label>";
    $display_block .= "<span class=\"formresult\" id=\"datereceived\">".$feat_dater."</span><br />";
    $display_block .= "<label for=\"synopsis\">Synopsis:</label>";
    $display_block .= "<span class=\"formresult\" id=\"synopsis\">".$feat_synopsis."</span><br />";
    $display_block .= "</div>";
}
}
?>
<html>
<head>
<title>Galway Film Fleadh - View Submitted Feature Films</title>
<link href="css/submissions.css" rel="stylesheet" type="text/css" />
</head>

<body>
<div id="wrapper">
    <div class="inner">
        <h1>Galway Film Fleadh - View Submitted Films</h1>
    </div>
    <?php
        print $display_block;
    ?>
</div>        
</body>
</html>

Ed Gibbs · Accepted Answer · 2013-03-28 16:04:43Z

4

You're overwriting $display_block for each loop iteration:

$display_block = "<div class=\"inner\">";

Define it before the loop, then change the line above to this:

$display_block .= "<div class=\"inner\">";

answered Mar 28, 2013 at 16:04

Ed Gibbs

26.4k4 gold badges50 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

TheEwook · Accepted Answer · 2013-03-28 16:04:57Z

3

replace this line

$display_block = "<div class=\"inner\">";

by

$display_block .= "<div class=\"inner\">";

answered Mar 28, 2013 at 16:04

TheEwook

11.2k6 gold badges39 silver badges55 bronze badges

Comments

alwaysLearn · Accepted Answer · 2013-03-28 16:10:35Z

2

since

 $display_block = "<div class=\"inner\">";

is inside the loop so after every iteration in while loop the div gets instanstiated ....

you need to keep the old values so you have to concatenate it ... replace it with

 $display_block .= "<div class=\"inner\">";

answered Mar 28, 2013 at 16:10

alwaysLearn

6,9507 gold badges45 silver badges69 bronze badges

Comments

Vassilis Barzokas · Accepted Answer · 2013-03-28 16:05:24Z

1

$display_block = "<div class=\"inner\">";

Is inside the while loop, so each time it iterates it gets a new value and does not hold the previous.

answered Mar 28, 2013 at 16:05

Vassilis Barzokas

3,2822 gold badges29 silver badges42 bronze badges

Comments

Andrew · Accepted Answer · 2013-03-28 16:04:23Z

0

Try changing your while to:

while($feat_array = mysql_fetch_array($r_get_features, MYSQLI_ASSOC)) {
...

answered Mar 28, 2013 at 16:04

Andrew

2,0131 gold badge23 silver badges40 bronze badges

Collectives™ on Stack Overflow

PHP/MySQL - while loop only showing latest entered record

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related