Array.push, array stays empty

Question

I'm trying to get all hget values out of my redis db. But the array logs stays empty. Could you guys please take a look into it? Thanks

getAllHMSets = (cb) ->
  client.keys "log:*", (err, logKeys) ->
    if not err and logKeys isnt null
      logs = new Array()
      i = 0
      while i < logKeys.length
        client.hgetall logKeys[i], (err, log) ->
          if not err and log isnt null
            logs.push log
        i++

      if logs.length is logKeys.length
        cb logs  if typeof cb is "function"

Could it be that hgetall is executed asynchronously (that would explain the use of a callback)? — Thilo
– Thilo, Commented Mar 17, 2013 at 23:30
Thanks, Thilo. HGETALL is async, I'm using redis.multi() now which solves the issue ;) — krnflake
– krnflake, Commented Mar 17, 2013 at 23:59

robkuz · Accepted Answer · 2013-03-18 20:42:46Z

2

I think there are 2 problems with your code:

you should write it in more idiomatic CoffeeScript
your call to hgetall must also use a callback eitherwise your array will never be filled.

getAllHMSets = (cb) ->
  client.keys "log:*", (err, logKeys) ->
    if not err and logKeys isnt null

      logs = []

      for value in logKeys
        client.hgetall logKeys[i], (err, log) ->
          if not err and log isnt null
            logs.push log
            if logs.length is logKeys.length
              cb logs  if typeof cb is "function"

edited Mar 18, 2013 at 20:42

answered Mar 18, 2013 at 11:33

robkuz

10k5 gold badges34 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Ven Over a year ago

either your indentation is busted or you miss a return

robkuz Over a year ago

oops! where do I miss a return?

Ven Over a year ago

if not err and logKeys isnt null

robkuz Over a year ago

sorry, I dont get it. Why would there be a return missing? What should a return at this position do?

Ven Over a year ago

your if here is basically useless since you don't have anything in it. Actually coffee will refuse to parse it since it's not a post if (there's nothing before) and it has no block

|

Collectives™ on Stack Overflow

Array.push, array stays empty

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related