Dynamically change text based on URL input

Question

I am using the following code to dynamically change the text on my clients website (www.mydomain.com.au):

<script type="text/javascript">// <![CDATA[
       var url = window.location.toString();
       var query_string = url.split("?");
               if (query_string[1]) {
       var params = query_string[1].split("&#038;");
       var param_item = params[0].split("=");
       param_item[param_item[0]] = unescape(param_item[1]);
       document.write(param_item["city"]);
               } else {
                       document.write("24 Hour Glass Replacement");
               }
// ]]&gt;</script>

It works perfectly fine on the index page. e.g. www.mydomain.com.au/?city=test

but when I am using the same code on other pages e.g. http://www.mydomain.com.au/Brisbane.html/?city=test I get a 404 error.

Appreciate any help

it's totally logic... you only use the QUERY-String, "all which is prefixed by the '?'". you'll have to check, if there is a query-string and parameter called "city" and if not, use the LAST word after a slash and before the file-suffix. — TheHe
– TheHe, Commented Mar 7, 2013 at 4:02

Michael Petrotta · Accepted Answer · 2013-07-13 01:57:38Z

1

Remove the / before starting querystring. So, try http://www.mydomain.com.au/Brisbane.html?city=test instead of http://www.mydomain.com.au/Brisbane.html/?city=test

edited Jul 13, 2013 at 1:57

Michael Petrotta

61.1k27 gold badges153 silver badges181 bronze badges

answered Mar 7, 2013 at 4:08

Shahdat

5,5234 gold badges42 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

iGanja Over a year ago

normally that / would not cause a problem, but that could be why you are getting a 404.

iGanja Over a year ago

I would also recommend you use location.search instead of parsing the entire url.

Shahdat Over a year ago

@MohammadMoezzi please do not forgot to select it as answer and vote if you think my answer is correct and helpful. thanks :)

Webnerdoz Over a year ago

@Shahdat unfortunately I do not have a voting power yet but I promise I'll do it when I could. Thanks

Shahdat Over a year ago

@MohammadMoezzi yes, I see but you can click on the tick to select it as answer of your question. thanks

|

Collectives™ on Stack Overflow

Dynamically change text based on URL input

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related