PHP call class method to another class

Question

I've 3 class (Mysqliconn, Users and News).

Mysqliconn.class

Class Mysqliconn {
..connect to db
}

News.class

class News {
private $db;

   public function __construct( Mysqliconn $db ) {

   $this->db = $db; 
   }

   public test() {
     do something... 
   }
 }

Users.class

class Users {
private $db;

   public function __construct( Mysqliconn $db ) {

   $this->db = $db; 
   }

   public test2() {

     do something...
   }
}

In my php page

 $db = new Mysqliconn();
 $nw = new News( $db );
 $us = new Users( $db )

 $us->test2();
 $nw->test();

My error

Catchable fatal error: Argument 1 
passed to Users::__construct() must be an instance of Mysqliconn, 
none given, called in ....\class\class.news.php

Now in my class Users I would like to to call a News class method, but I get an error if I try to istantiate the class News inside class Users.

How can I do this? Thanks.

What error? Class doesn't exist? Have you included the class file? — Damien Pirsy
– Damien Pirsy, Commented Feb 28, 2013 at 13:07
why don't you inject your News class in your User constructor? — JamesHalsall
– JamesHalsall, Commented Feb 28, 2013 at 13:08
Users doesn't make sense. How do you have a single Users? — Waleed Khan
– Waleed Khan, Commented Feb 28, 2013 at 13:09
Why do you pass the $db as a parameter? I would create a singleton class for the Database class. — Chris
– Chris, Commented Feb 28, 2013 at 13:11

Federkun · Accepted Answer · 2013-02-28 13:43:46Z

1

Plz post what error you are getting. Otherwise it's difficult to capture the problem. But if you dont want to instantiate the news class in the user class you can access it like

class News
{
    // news class
}

class Users
{
    public function some_method(News $news){
        // work with the $news object
    }
}

$us = new Users();
$us->some_method(new News(/*$db*/));

This is just a basic code to give you an idea of how you can use it. In a production environment you have to take a lot of precautions.

edited Feb 28, 2013 at 13:43

Federkun

37.2k8 gold badges82 silver badges93 bronze badges

answered Feb 28, 2013 at 13:13

Sid

8561 gold badge9 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

peter.svintsitskiy Over a year ago

It's a bad idea. Your code doesn't even work. And it's not a singleton either.

Federkun Over a year ago

still not a singleton: remove function instance() and calls it dependency injection

Collectives™ on Stack Overflow

PHP call class method to another class

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related