Rails Query: Undefined Method for nil:NilClass

Question

In my Rails app, I have projects that have many steps, and each step has many images.

I'm trying to tag links to pages about each step with information about the step, particularly the name of the step and the default image associated with the step.

<%= link_to "", project_step_path(@project, i), :class=> "dot", 
data: {title: steps.find_by_number(i).name, 
image: steps.find_by_number(i).images.order("position ASC").first.file} %>

The title data tag does return the name of the step, but I'm getting an error with my image data tag. When I try it in the rails console, it returns the file path to the image, but when I try to implement it in my app, I get the error undefined method `file' for nil:NilClass.

When I remove "file" from my image tag (so it's image: steps.find_by_number(i).images.order("position ASC").first), and I return what the image data tag is for each link, I get [object Object].

How can I get it to return the right query result?

Here is my steps controller:

class StepsController < ApplicationController

  before_filter :get_project

  def show
    @step = @project.steps.find_by_number(params[:id])
    @image = Image.new
    @images = @step.images.order("position")
    @steps = @project.steps.order("number")
    @numSteps = @steps.count

    respond_to do |format|
      format.html # show.html.erb
      format.json { render :json => @step }
    end
  end
  private
  # get_project converts the project_id given by the routing
  # into an @project object
  def get_project
    @project = Project.find(params[:project_id])
  end
end

Can you post your controller code?

eabraham
– eabraham

2013-02-10 18:51:54 +00:00
Commented Feb 10, 2013 at 18:51 — eabraham
– eabraham, Commented Feb 10, 2013 at 18:51

sameera207 · Accepted Answer · 2013-02-10 19:01:42Z

1

reason for this is the following entire thing becomes nil

images.order("position ASC").first

most possible problem might be is when you select steps by i, there can be a dataset which doesnot have images

to avoid getting this error, one thing you could do is use try

steps.find_by_number(i).images.order("position ASC").first.try(:file)

answered Feb 10, 2013 at 19:01

sameera207

16.6k20 gold badges92 silver badges156 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

scientiffic Over a year ago

hey, this works! I ended up discovering this right when you were posting your response; because some steps don't currently have images, it wasn't able to find file paths. I'm still running into a problem where the file path is returned as [object Object] - I'm expect it to look like "/image/file/190/01_00.jpg"

scientiffic Over a year ago

interesting, I tried indexing the object array (didn't know if this was how to do it), but I got the error: undefined method `[]' for /image/file/190/01_00.jpg:FileUploader So it seems like it is getting the file path, but it's attaching this :FileUploader to it?

sameera207 Over a year ago

glad to help, and if you want to get something like '/image/file/190/01_00.jpg', then you should probably use something like file.file_name. coz I think file is the object, and you need to call the method which returns the file name.

Collectives™ on Stack Overflow

Rails Query: Undefined Method for nil:NilClass

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related