Mysql result as array

Question

I have a php function that interogates a table and gets all the fields in a column if a condition is fulfield. So the function returns a collection of elements. The problem is that i want this function to return an array that i can parse and display. The code below:

function get_approved_pictures(){
    $con = mysql_connect("localhost","valentinesapp","fBsKAd8RXrfQvBcn");
    if (!$con)
    { 
      echo 'eroare de conexiune';
      die('Could not connect: ' . mysql_error());
    }

    mysql_select_db("mynameisbrand_valentineapp", $con);

    $all = (mysql_query("SELECT picture FROM users WHERE approved = 1")); 

    $row=mysql_fetch_assoc($all);
     //  mysql_close($con);

    return $row['picture']; 
  }

Where am I wrong?

do not connect inside of every function. connect only once at the beginning of your code, and then just use the established connection all the way through — Your Common Sense
– Your Common Sense, Commented Feb 9, 2013 at 9:58

dev-null-dweller · Accepted Answer · 2013-02-09 09:04:18Z

3

You need to use the loop for traversing all the data fetched by the query:

$pictures=array();
while($row=mysql_fetch_assoc($all))
{
    $pictures[]=$row['picture']; 
}
return $pictures;

edited Feb 9, 2013 at 9:04

dev-null-dweller

29.5k3 gold badges68 silver badges87 bronze badges

answered Feb 9, 2013 at 9:00

luckystars

1,75412 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Roger · Accepted Answer · 2013-02-09 09:03:34Z

0

Do it like this

$all = mysql_query("SELECT picture FROM users WHERE approved = 1"); 
$arr = array(); // Array to hold the datas
while($row = mysql_fetch_array($all)) {
  $data = $row['picture'];
  array_push($arr,$data);
}
return $arr;

You can now insert it into a function and return the values.

Note : mysql_* functions are being depreciated. Try to avoid them.

answered Feb 9, 2013 at 9:03

Roger

1,7011 gold badge18 silver badges34 bronze badges

Comments

peterm · Accepted Answer · 2013-02-09 09:28:45Z

-1

For the sake of diversity and to give you some sense of how to use PDO instead of deprecated mysql_*, this is how your function might look like:

function get_approved_pictures(){
    $db = new PDO('mysql:host=localhost;dbname=mynameisbrand_valentineapp;charset=UTF-8',
                  'valentinesapp', 'password');
    $query = $db->prepare("SELECT picture FROM users WHERE approved = 1");
    $query->execute();
    $pictures = $query->fetchAll(PDO::FETCH_ASSOC);
    $db = null;
    return $pictures;
}

Disclaimer: all error handling intentionally omitted for brevity

answered Feb 9, 2013 at 9:28

peterm

93k16 gold badges157 silver badges162 bronze badges

Comments

Your Common Sense · Accepted Answer · 2013-02-09 09:52:07Z

-1

For the sake of diversity and to give you some sense of how the things have to be instead of inconvenient and wordy PDO, this is how your function might look like:

function get_approved_pictures(){
    global $db;
    return $db->getCol("SELECT picture FROM users WHERE approved = 1");
}

Disclaimer: all error handling is up and running but intentionally encapsulated into private methods for invisibility.

edited Feb 9, 2013 at 9:52

answered Feb 9, 2013 at 9:41

Your Common Sense

158k42 gold badges226 silver badges373 bronze badges

Collectives™ on Stack Overflow

Mysql result as array

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related