java display method

Question

Here im required to Write a method printArray that displays the contents of the array num and Display the contents of the array with each number separated by a space. and i have to start a new line after every 20 elements.

i wrote this code but whenever i try to execute it, it shows the array without the new line

public class project2 {

    public static void main(String[] args) {

        int num []= new int [100];

        for (int i=0;i<num.length;i++){

            num[i]=-1;
            num[7]=7;
        }


        printArray(num);
        System.out.println(num);


    }

    public static void printArray (int array1[]){

        int count =20;
        for (int x=0;x<array1.length;x++){

            System.out.print(array1[x]+" ");
            if (array1[x]==count){

                System.out.println(" ");
                count=array1[x]+count;

            }

        }
    }
}

Instead of 20 first go for 3 and work it out in your head. Do you know the modulo operator % ? — Joop Eggen
– Joop Eggen, Commented Jan 24, 2013 at 9:16

Boris Pavlović · Accepted Answer · 2013-01-24 09:25:35Z

1

import java.util.Arrays;
import java.util.Random;

public class project2 {

  public static void main(String[] args) {

    int num[] = new int[100];

    Random random = new Random();
    for (int i = 0; i < num.length; i++) {

      num[i] = random.nextInt(100);
    }


    printArray(num);

    System.out.println('\n' + Arrays.toString(num));
  }

  public static void printArray(int array1[]) {

    int count = 20;
    for (int i = 0; i < array1.length; i++) {

      System.out.printf("%2d ", array1[i]);
      if ((i + 1) % count == 0) {

        System.out.println("");
      }

    }
  }
}

answered Jan 24, 2013 at 9:25

Boris Pavlović

64.9k29 gold badges127 silver badges150 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ppeterka · Accepted Answer · 2013-01-24 09:23:43Z

0

You should use the modulo (or remainder) operator (%), that suits your usage much better:

for (int x=0;x<array1.length;x++){
    System.out.print(array1[x]+" ");
    if (x>0 && (x%count)==0){
        System.out.println(" ");
    }

}

This way, you will get a new line every count characters, and the first line will not have it (that is why the x>0 check is there).

Also, in the original post, this line is frankly totally bad:

count=array1[x]+count;

Just what would it do? Why do you add the value stored in the array to the fixed counter? Considering this line, I advise that you should really sit back a bit, and try to think about how things work in the background... There is no magic!

edited Jan 24, 2013 at 9:23

answered Jan 24, 2013 at 9:17

ppeterka

20.8k6 gold badges67 silver badges80 bronze badges

Comments

azraelAT · Accepted Answer · 2013-01-24 09:17:52Z

0

Take a closer look at your if-statement:

if (array1[x]==count)

According to your array values, this will never return true

answered Jan 24, 2013 at 9:17

azraelAT

7625 silver badges9 bronze badges

Comments

Azodious · Accepted Answer · 2013-01-24 09:18:15Z

0

i have to start a new line after every 20 elements.

Change to following code:

if (x%20 == 0)
{
    System.out.println();
}

in place of

if (array1[x]==count)
{
    System.out.println(" ");
    count=array1[x]+count;
}

answered Jan 24, 2013 at 9:18

Azodious

13.9k1 gold badge41 silver badges75 bronze badges

Comments

Ajinkya · Accepted Answer · 2013-01-24 09:20:54Z

0

Problem is with
if (array1[x]==count)
You are comparing count with value present in array. Instead compare it with desired count ie 20 or Use modulo operator as suggested in other answers / comments .

int count = 1;
for (int x=0;x<array1.length;x++){

    System.out.print(array1[x]+" ");

    if (count == 20){    // Check if its 20th element 
       System.out.println(" ");
       count=1;  // reset count 
    }
   count++;
}

edited Jan 24, 2013 at 9:20

answered Jan 24, 2013 at 9:15

Ajinkya

22.7k33 gold badges113 silver badges164 bronze badges

Collectives™ on Stack Overflow

java display method

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related