python mysql fetch query

Question

def dispcar ( self, reg ):
                print ("The car information for '%s' is: "), (reg)
                numrows = int(self.dbc.rowcount) #get the count of total rows
                self.dbc.execute("select * from car where reg='%s'") %(reg)
                for x in range(0, numrows):
                    car_info = self.dbc.fetchone()
                    print row[0], "-->", row[1]

the above code gives this error:

self.dbc.execute("select * from car where reg='%s' " %(reg)
TypeError: unsupported operand type(s) for %: 'long' and 'str'

can anyone please help me understand why am i getting this error?

FYI: reg is a raw_input var i input from user in the function getitem and pass the reg var as an argument to this function.

mluebke · Accepted Answer · 2009-09-11 21:49:12Z

4

This confuses just about everyone who works with MySQLDB. You are passing arguments to the execute function, not doing python string substitution. The %s in the query string is used more like a prepared statement than a python string substitution. This also prevents SQL injection as MySQLDB will do the escaping for you. As you had it before (using % and string substitution), you are vulnerable to injection.

Don't use quotes. MySQLDB will put them there (if needed).
Use a , instead of a %. Again, you are passing a tuple as an argument to the execute function.

self.dbc.execute("select * from car where reg=%s" , (reg,))

answered Sep 11, 2009 at 21:49

mluebke

8,8697 gold badges38 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ned Batchelder · Accepted Answer · 2009-09-11 20:26:48Z

3

I think this line simply has the parens in the wrong place:

self.dbc.execute("select * from car where reg='%s'") %(reg)

You are using % on the result of execute(), and reg.

Change it to:

self.dbc.execute("select * from car where reg='%s'" % reg)

or

self.dbc.execute("select * from car where reg='%s'", reg)

depending on whether it will do the param substitution for you.

answered Sep 11, 2009 at 20:26

Ned Batchelder

378k77 gold badges583 silver badges675 bronze badges

2 Comments

amit Over a year ago

this does help out a bit. but it is not fetching the data from the database? is something else wrong too?

ChristopheD Over a year ago

probably related to getting the rowcount before executing the query?

ChristopheD · Accepted Answer · 2009-09-11 22:26:46Z

1

You got the brackets wrong:

self.dbc.execute("select * from car where reg=%s" , (reg,))

Any particular reason you are looping using fetchone (in this ugly loop with a range based on a rowcount which will probably be zero as you get it before you execute the query)?

Just do

for car_info in self.dbc.fetchall():
    ....

edited Sep 11, 2009 at 22:26

answered Sep 11, 2009 at 20:27

ChristopheD

117k30 gold badges167 silver badges182 bronze badges

Collectives™ on Stack Overflow

python mysql fetch query

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related