Retrieve stuff from database in ASP.NET MVC

Question

How do you mix the concepts of ASP.NET MVC and entityframework in a elegant and robust way when it comes to retrieving stuff from the database and visualizing it via the controller and view?

The example below will throw Dispose exceptions because the View will be displayed after the using statement is closed.

        // code in controller
        using (var usersDb = new UsersDb(new WebSecurityWrapper()))
        {
            var user = usersDb.GetUser(User.Identity.Name);
            return View(user);
        }

        // code in usersDb model -- GetUser method
        public User GetUser(string name)
        {
            var id = _webSecurity.GetUserId(name);
            var user = Users.FirstOrDefault(usr => usr.Id == id);

            return user;
        }

Pretty obvious, but the only alternative I can think of is "cloning" the user object so that the View can display it independently. That doesn't feel right.

So what's the appropriate way of doing this?

Assign user outside of the using then? Heres a good tutorial about databases mvc: asp.net/mvc/tutorials/older-versions/movie-database/… — Nate-Wilkins
– Nate-Wilkins, Commented Jan 1, 2013 at 16:13
Hi Kirill I updated the question with the implementation of GetUser. — bas
– bas, Commented Jan 1, 2013 at 16:40
Hi Nate, I think you mean "declare user outside the using"? That doesn't work either since I access the user variable outside the scope of the using. The solution that your tutorial provides is indeed not using a using statement. That works. But is that the way to go? Because now the object will get disposed whenever the garbage collector decides when to finalize the usersDb object which ran out of scope when the controller method is executed. That doesn't seem a healthy solution or am I misunderstanding some things here? — bas
– bas, Commented Jan 1, 2013 at 16:44
Have you tried your return View statement outside the scope of the using? — Greg Smith
– Greg Smith, Commented Jan 1, 2013 at 16:46

Community · Accepted Answer · 2017-05-23 12:04:32Z

1

I think you are using navigation properties of the User object in the view. These are probably evaluated in a lazy way.

The User object is created before you exit the method. Somehow you are requesting extra info which is queried in the view. But since the dispose already happended, this results in the exception.

One option is to use Include to immediately query the extra necessary data.

edited May 23, 2017 at 12:04

CommunityBot

11 silver badge

answered Jan 1, 2013 at 18:01

Maarten

23k3 gold badges51 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Greg Smith · Accepted Answer · 2013-01-01 16:39:42Z

0

    User user;
    using (var usersDb = new UsersDb(new WebSecurityWrapper()))
    {
        user = usersDb.GetUser(User.Identity.Name);
    }

    return View(user);

answered Jan 1, 2013 at 16:39

Greg Smith

2,4692 gold badges24 silver badges37 bronze badges

4 Comments

bas Over a year ago

Hi Greg, thx for the suggestion but that results in the exact same problem since the user object is used outside the scope of the using statement (namely, in the View). Removing the using statement works, but as I mentioned in a comment above that feels kinda tricky since the dispose method will be called whenever the garbage collector decides to finalize the usersDb object.

Greg Smith Over a year ago

Ok, have you thought about using a repository and unit of work style pattern - this is a pretty effective and easy to achieve setup, it's also very widely used, documented nicely here: asp.net/mvc/tutorials/getting-started-with-ef-using-mvc/…

bas Over a year ago

reading through it right now. Great link! Will reply when done reading. Also a link to TDD with MVC/EF (!!).

bas Over a year ago

Awesome material! I'll adjust the design to their repository and unit of work pattern. Many thx for the link! PS: Maarten just gave the answer that solves my problem. I had to include something in the query.

Collectives™ on Stack Overflow

Retrieve stuff from database in ASP.NET MVC

2 Answers 2

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related