Php Image upload script

Question

Hi thx to tutorials and own hinking I wrote this code

if(isset($_POST['upload'])) {

$allowed_filetypes = array('.jpg','.jpeg','.png','.gif');
$max_filesize = 10485760;
$upload_path = 'uploads/';
$description = $_POST['imgdesc'];

$filename = $_FILES['userfile']['name'];
$ext = substr($filename, strpos($filename,'.'), strlen($filename)-1);

if(!in_array($ext,$allowed_filetypes))
  die('The file you attempted to upload is not allowed.');

if(filesize($_FILES['userfile']['tmp_name']) > $max_filesize)
  die('The file you attempted to upload is too large.');

if(!is_writable($upload_path))
  die('You cannot upload to the specified directory, please CHMOD it to 777.');

if(move_uploaded_file($_FILES['userfile']['tmp_name'],$upload_path . $filename)) {
   $query = "INSERT INTO uploads (name, description) VALUES ($filename, $description)"; 
   mysql_query($query);

echo 'Your file upload was successful!';


} else {
     echo 'There was an error during the file upload.  Please try again.';
}
}

I'm getting this error;

Notice: Undefined index: userfile in C:\WebServer\htdocs\PicSide\admin\addimage.php on line 16

How to fix it anyone know? And is this correct to upload o server?

can you post your html form, we need to see that as well? also notices are not exactly errors, errors stops the rest of the script from running whereas notices - depending on the server environment - do not. — ncremins
– ncremins, Commented Dec 28, 2012 at 23:11
1st Thank you for reply, I noticed I didn't name my input by "userfile" dummy me, but otherwise is this code correct? — Piggie
– Piggie, Commented Dec 28, 2012 at 23:13
@creminsn, Notices are not errors? I wonder why it is an option in PHP error reporting? =oP It is an error, just a less severe error. Notices should be fixed as having them means the code is not properly being done to account for variables not existing, which does not make robust code. — user1592648
– user1592648, Commented Dec 28, 2012 at 23:18
You shouldn't be telling anyone to CHMOD directories to 777. CHMODing to 777 is a very amateurish way to get around actually dealing with user file permissions in an appropriate manner. — Mike Brant
– Mike Brant, Commented Dec 28, 2012 at 23:18

karllindmark · Accepted Answer · 2012-12-28 23:14:45Z

5

Basically, what your error means is that you don't have the following (or somewhat similar) element in your form:

<input type="file" name="userfile" />

The important part in this is the actual name="userfile" which specifies the key in the $_FILES array.

answered Dec 28, 2012 at 23:14

karllindmark

6,0601 gold badge28 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Piggie Over a year ago

Thanks! I actually found it out 1min after posting this, I noticed to late, sorry for unnecessary post

user1592648 Over a year ago

@Piggie, I personally would mark ninetwozero's as the solution.

AstroCB · Accepted Answer · 2014-10-21 01:01:09Z

0

And don't forget to concat:

$query = "INSERT INTO uploads (name, description) VALUES ($filename, $description)";

Should be:

$query = "INSERT INTO uploads (name, description) VALUES (".$filename.", ".$description.")";

edited Oct 21, 2014 at 1:01

AstroCB

12.4k20 gold badges59 silver badges75 bronze badges

answered Oct 21, 2014 at 0:56

YanYan

215 bronze badges

Comments

Thilina · Accepted Answer · 2016-07-11 06:49:52Z

0

<form>
<input type="file" name="userfile" />
</form>

$allowed_filetypes = array('.jpg','.jpeg','.png','.gif');
$max_filesize = 10485760;
$upload_path = 'uploads/';
$description = $_POST['imgdesc'];
$filename = $_FILES['userfile']['name'];
if(move_uploaded_file($_FILES['userfile']['tmp_name'],$upload_path . $filename)) {
   $query = "INSERT INTO uploads (name, description) VALUES ($filename, $description)"; 
   mysql_query($query);

echo 'Your file upload was successful!';


}

answered Jul 11, 2016 at 6:49

Thilina

932 silver badges7 bronze badges

Comments

Bidhan Gorai · Accepted Answer · 2015-01-24 05:37:53Z

-2

<?php
error_reporting(0);
?>

answered Jan 24, 2015 at 5:37

Bidhan Gorai

1

1 Comment

chappjc Over a year ago

Funny. Great solution

Collectives™ on Stack Overflow

Php Image upload script

4 Answers 4

2 Comments

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related