javascript pass eval variables

Question

i have eval function, which needs to execute javascript from php. but i need to pass element, so i can put mouse over tips on the link user clicked on.

var globalEval = function globalEval(src, element) {
        if (window.execScript) {
            window.execScript(src);
            return;
        }
        var fn = function(element) {
            window.eval.call(window,src);
        };
        fn(element);
    };

im using following way to pass $(this) element

globalEval(js_code, $(this));
// js_code is = alert(element);

i get error of undefined element, which is defined in globalEval(); how can i fix this?

If I'm correct in assuming src is always a string, what happens if you do window.eval.call(window,'(function (element) {'+src+'})')(element);? — Paul S.
– Paul S., Commented Dec 16, 2012 at 22:42

Community · Accepted Answer · 2017-05-23 10:28:50Z

12

This is a scoping issue as the global eval isn't invoking the code in the same scope as the variable element. If you must use eval even though eval is evil, you'll have to do it in a way that lets you invoke your code in the environment you want. One way to do this is to wrap it as an anonymous function which you give parameters for the environment variables of choice.

For example

window.eval.call(window,'(function (element) {'+src+'})')(element);

This means the src string is parsed but not invoked by the eval as it returns an anonymous function. You then invoke it, passing your data, in this case element.

Test it with var element = document.body, src = 'console.log(element.tagName)'; and you'll see it log "BODY". Please note that if you want to set global variables (or functions) this way they have to be stated as global explicitly (window.foobar = ...) or they will be GCd after the anonymous function finishes.

edited May 23, 2017 at 10:28

CommunityBot

11 silver badge

answered Dec 16, 2012 at 22:53

Paul S.

66.6k9 gold badges129 silver badges143 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Esailija Over a year ago

Why not just local eval(src), it would pick up element

Paul S. Over a year ago

@Esailija Because I like to over-complicate things. No, the way in my answer means you specify the environment by passing variables and protect your current environment (because function is ByVal, a change such as element = otherElm doesn't effect where you invoked it) whereas a local eval(src) would use the current environment. There are other options it gives you about invoking it (e.g. var-ing it / using .call). I'm not saying eval is ever "safe", but at least this way means you can call in the environment you want (assuming src is valid JavaScript).

Basit Over a year ago

@PaulS. Thanks alot. this works fine now :). btw will this work also window.execScript('(function (element) {'+src+'})')(element); ?

geocar Over a year ago

You should use the Function constructor instead: It reports (syntax) errors better.

Paul S. Over a year ago

@geocar +1 because I agree, but doing that doesn't involve eval, which isn't OP's question.

|

geocar · Accepted Answer · 2012-12-16 23:17:00Z

7

If all you want to do is have this set when you evaluate some code, try:

// Code you want to evaluate
var code = 'return this.whatever'

// What you want "this" bound to:
var that = { whatever: 69 }

// Now do this:
var result = new Function(code).call(that)

Using the Function constructor means you'll get what you expect; There is a lot of baggage that comes along with global eval, some of which might surprise you. Best to avoid it if you don't need it.

Now if you really wanted to call it element, the Function constructor can do that as well:

code = 'alert(element)'
var use_element = 69
result = new Function("element", code).call(this, use_element)

edited Dec 16, 2012 at 23:17

answered Dec 16, 2012 at 23:07

geocar

9,3631 gold badge32 silver badges37 bronze badges

2 Comments

Basit Over a year ago

i like your suggestion. just wondering if its supported by older browsers and if any dynamic code of javascript from php will execute fine wihtout errors?

geocar Over a year ago

@Basit - See aptana.com/reference/api/Function.html for browser compatibility. PHP doesn't enter into it, you can simply do something like: result = new Function("element", <?= json_encode($code) ?>).call(this, use_element) if you like.

Volkan Talayhan · Accepted Answer · 2021-01-31 02:22:32Z

0

if the callback function is in the same dom, then set a global variable as repo before eval which will keep the variable. then use the global variable in the function you gonna call.

var response_repo;
function someFunc($callback){
 ....
 success: function(result) {
            response_repo = result;
            eval($callback+'();');
        },
 ....
 }


 callBackFunc(){
  $data=response_repo;
 }

answered Jan 31, 2021 at 2:22

Volkan Talayhan

362 bronze badges

Collectives™ on Stack Overflow

javascript pass eval variables

3 Answers 3

10 Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

10 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related