Javascript merge object with nested properties

Question

Lets take a look at the example below:

var ref = {
    "fullName": {
        "rules": {
            "type": "string",
            "minLength": 4,
            "maxLength": 64
        },
        "description": "Full name of a user."
    }
};

var user = {
    "fullName": {
        "rules": {
            "required": true,
            "maxLength": 128
        },
        "message": "You have submitted a wrong full name."
    }
};

Now what I want is this:

Merge objects & properties.
Keep the properties of the second object IF they are set already (maxLength)

Below is the result that I expect:

var res = {
    "fullName": {
        "rules": {
            "required": true,
            "maxLength": 128
            "type": "string",
            "minLength": 4
        },
        "description": "Full name of a user.",
        "message": "You have submitted a wrong full name."
    }
};

What I have tried:

function mergeNestedObjects(firstObject, secondObject) {
    var finalObject = {};
    
    for (var propertyKey in firstObject) {
        var propertyValue = firstObject[propertyKey];
        
        if (typeof(propertyValue) === "object") {
            finalObject[propertyKey] = mergeNestedObjects(firstObject[propertyKey], secondObject[propertyKey]);
        } else if (secondObject[propertyKey] === undefined) {
            finalObject[propertyKey] = firstObject[propertyKey];
        } else {
            finalObject[propertyKey] = secondObject[propertyKey];
        }
    }
    
    return finalObject;
}

The function above merges but somehow doesnt nest the properties.

UPDATE & ANSWER got it working, I forgot too itterate through the second object, how dumb. Thanks to @AnthonyGrist

function mergeProperties(propertyKey, firstObject, secondObject) {
    var propertyValue = firstObject[propertyKey];

    if (typeof(propertyValue) === "object") {
        return mergeNestedObjects(firstObject[propertyKey], secondObject[propertyKey]);
    } else if (secondObject === undefined || secondObject[propertyKey] === undefined) {
        return firstObject[propertyKey];
    }
    
    return secondObject[propertyKey];
}

function mergeNestedObjects(firstObject, secondObject) {
    var finalObject = {};
    
    // Merge first object and its properties.
    for (var propertyKey in firstObject) {
        finalObject[propertyKey] = mergeProperties(propertyKey, firstObject, secondObject);
    }

    // Merge second object and its properties.
    for (var propertyKey in secondObject) {
        finalObject[propertyKey] = mergeProperties(propertyKey, secondObject, firstObject);
    }
    
    return finalObject;
}

You're only ever iterating over the keys of firstObject, so your resulting object is only ever going to have the same keys as the first object passed in. You'll also need to iterate over the keys of secondObject, and add those which are missing. — Anthony Grist
– Anthony Grist, Commented Dec 13, 2012 at 13:59
@onlineracoon: I tried your code, and the properties nest correctly. The only issue is that some of the properties are missing, as Anthony pointed out. — RonaldBarzell
– RonaldBarzell, Commented Dec 13, 2012 at 14:01
@AnthonyGrist that worked, how stupid of me lol. Now however I got this: pastebin.com/Zma8kLY6 can it be made any shorter, it looks like im doing alot of duplicated code — onlineracoon
– onlineracoon, Commented Dec 13, 2012 at 14:02
@onlineracoon You may answer your own question and mark it as accepted. :) — dan-lee
– dan-lee, Commented Dec 13, 2012 at 14:05
I want @AnthonyGrist to answer it, since he gave the answer and he deserves the credits — onlineracoon
– onlineracoon, Commented Dec 13, 2012 at 14:05

onlineracoon · Accepted Answer · 2013-01-14 10:03:37Z

6

function mergeProperties(propertyKey, firstObject, secondObject) {
    var propertyValue = firstObject[propertyKey];

    if (typeof(propertyValue) === "object") {
        return mergeNestedObjects(firstObject[propertyKey], secondObject[propertyKey]);
    } else if (secondObject[propertyKey] === undefined) {
        return firstObject[propertyKey];
    }

    return secondObject[propertyKey];
}

function mergeNestedObjects(firstObject, secondObject) {
    var finalObject = {};

    // Merge first object and its properties.
    for (var propertyKey in firstObject) {
        finalObject[propertyKey] = mergeProperties(propertyKey, firstObject, secondObject);
    }

    // Merge second object and its properties.
    for (var propertyKey in secondObject) {
        finalObject[propertyKey] = mergeProperties(propertyKey, secondObject, firstObject);
    }

    return finalObject;
}

answered Jan 14, 2013 at 10:03

onlineracoon

2,9705 gold badges49 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Abhinav Over a year ago

There is a flaw in this. This fails when we merge a = {a: {z: 1}, b: {y:1}, c:{z:1}}; b = {c:{zye: 1}}; Because we are not checking if the key exist in the second object in the call: return mergeNestedObjects(firstObject[propertyKey], secondObject[propertyKey])

Sarkis Arutiunian · Accepted Answer · 2016-10-27 23:05:55Z

2

Pretty old question, but can be useful. A little bit of recursion.

function mergeObjects(og, so) {
    for (var key in so) {
        if (typeof (og[key]) === 'object') {
            mergeObjects(og[key], so[key]);
        } else {
            if (og[key] || typeof (og[key]) === 'boolean') {
                og[key] = so[key];
            }
        }
    }
    return og;
}

mergeObjects(ref, user);

edited Oct 27, 2016 at 23:05

answered Oct 27, 2016 at 4:58

Sarkis Arutiunian

1,2913 gold badges18 silver badges36 bronze badges

Collectives™ on Stack Overflow

Javascript merge object with nested properties

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related