call javascript function on link click

Question

I want to set a cookie value when user clicks on a link. I am using the following code:

<script src="http://code.jquery.com/jquery-1.7.2.min.js"></script>
<script src="../../Scripts/jquery.cookie.js" type="text/javascript"></script>
<script type="text/javascript">
    $(document).ready(function () {

        function changeLang(lang) {
            $.cookie('myCulture', lang);
            window.location.reload();
            return false;
        }
    });

</script>

HTML

  <a href="#" onclick="changeLang('da-DK')"><img src="../../Content/images/danishFlag.png" height="35px" width="35px"/></a>

  <a href="#" onclick="changeLang('sv-SE')"><img src="../../Content/images/swedishFlag.png" height="35px" width="35px"/></a>

It looks like very simple code, but when I click on the link, there is an error in the browser. It says.

ReferenceError: changeLang is not defined   

changeLang("da-DK");

Where am I doing wrong??

relocate your function to out of document ready

AliRıza Adıyahşi
– AliRıza Adıyahşi

2012-12-06 10:31:32 +00:00
Commented Dec 6, 2012 at 10:31 — AliRıza Adıyahşi
– AliRıza Adıyahşi, Commented Dec 6, 2012 at 10:31

jxs · Accepted Answer · 2012-12-08 18:25:08Z

2

you are defining the function inside the document ready scope, so it's not global therefore not available in the global scope

define it as a global simply by removing the var declaration or using window.changeLang = function

 $(document).ready(function () {

       changeLang = function(lang) {
            document.cookie = 'myCulture' + lang;
            window.location.reload();
            return false;
        }
    });

edited Dec 8, 2012 at 18:25

answered Dec 6, 2012 at 10:33

jxs

4574 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pragnesh Chauhan · Accepted Answer · 2012-12-06 10:30:39Z

2

define function outside of the jquery block

$(document).ready(function () {
});

function changeLang(lang) {
        $.cookie('myCulture', lang);
        window.location.reload();
        return false;
    }

answered Dec 6, 2012 at 10:30

Pragnesh Chauhan

8,49410 gold badges46 silver badges58 bronze badges

2 Comments

Reza.Hoque Over a year ago

TypeError: $.cookie is not a function

Reza.Hoque Over a year ago

yes i have the file. i took it from here: github.com/carhartl/jquery-cookie

Peter Smith · Accepted Answer · 2012-12-06 10:33:25Z

0

Try moving the ChangeLang function to outside of the Document Ready section. Also, if running in FireFox with Firebug you can experiment with executing the function directly from the Console.

Good luck

answered Dec 6, 2012 at 10:33

Peter Smith

5,5529 gold badges54 silver badges80 bronze badges

Comments

Dziad Borowy · Accepted Answer · 2012-12-06 10:37:15Z

0

Please do not attach js functions in html like this. You're using jquery so just do this:

$(document).ready(function () {

    function changeLang() {
        $.cookie('myCulture', $(this).data('lang'));
        window.location.reload();
        return false;
    }
    $('.link').on('click', changeLang);
});

and then in html:

<a href="#" data-lang="da-DK">...</a>

edited Dec 6, 2012 at 10:37

answered Dec 6, 2012 at 10:32

Dziad Borowy

12.6k4 gold badges44 silver badges54 bronze badges

Comments

anuj arora · Accepted Answer · 2012-12-06 10:54:50Z

0

$(document).ready(function () {
});
function changeLang(lang) {
    document.cookie = 'myCulture=' + lang;
    window.location.reload();
    return false;
}

This will work for you.

answered Dec 6, 2012 at 10:54

anuj arora

83112 silver badges22 bronze badges

Collectives™ on Stack Overflow

call javascript function on link click

5 Answers 5

Comments

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related