unable to set $_SESSION variable with PHP variable

Question

Here is where I am setting my session variables.

function validateUser()
{
session_regenerate_id (); //this is a security measure
$_SESSION['user'] = $_POST['username'];
$_SESSION['valid'] = 1;
$_SESSION['firstname'] = $firstname;
$_SESSION['lastname'] = $lastname;
}

This is what print_r ($_SESSSION) echos.

Array ( [user] => aboshart [valid] => 1 [firstname] => [lastname] => )

If I echo $firstname and $lastname I get the proper values. What am I doing wrong?

$_SESSION vars are usually considered trusted as it is the developer who specifies what data the value is. You are setting a $_SESSION var to an unsanitized user supplied var by not sanitizing or validating $_POST['username'] Please do so before you accidentally use $_SESSION['user'] somewhere it can cause harm like in a database query. I assume you want a secure app judging from your PHP code comment. — user1592648
– user1592648, Commented Nov 30, 2012 at 19:44

Kai Qing · Accepted Answer · 2012-11-30 19:38:49Z

3

You're not passing $firstname or $lastname to the function.

function validateUser($firstname, $lastname)
{
    session_regenerate_id (); //this is a security measure
    $_SESSION['user'] = $_POST['username'];
    $_SESSION['valid'] = 1;
    $_SESSION['firstname'] = $firstname;
    $_SESSION['lastname'] = $lastname;
}

$_POST and $_SESSION should be within scope but the others aren't

answered Nov 30, 2012 at 19:38

Kai Qing

18.9k6 gold badges41 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Bogdan Stăncescu Over a year ago

What he said; plus, as a rule, watch the error log for notifications and warnings.

slinkfresh Over a year ago

Thanks! this is exactly what I need. The $_POST variable is there just to demonstrate that the validateUser function is working to set session variables. I will not be using it in live code.

Collectives™ on Stack Overflow

unable to set $_SESSION variable with PHP variable

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related