Copy Array of strings in C error

Question

I want to save about 20 country names into one string and then copy them to another but it always do me some mistake, can anybody help me with it?

This is my code:

char array1[30][30], array2[30][30];

This is how i put them into first array:

fscanf(fr, "%s", array1[i]);

This all works but when i want to do:

array2[0] = array1[0];

I get error:

incompatible types when assigning to type 'char[30]' from type 'char *'

When I use:

strcpy(array2[pom2], array1[i]);

it shows no error but doesn't copy it nor print it out.

Alberto Bonsanto · Accepted Answer · 2012-11-08 19:44:38Z

1

Did you try passing character by character?

for( i = 0; i < 30; i++ ){
   for( j = 0; j < 30; j++ ){
      targetArray[ i ][ j ] = sourceArray[ i ][ j ];

      /* End of the string, stop copying */
      if ( sourceArray[ i ][ j ] == '\0' ){
         break;
      }
   }
}

edited Nov 8, 2012 at 19:44

answered Nov 8, 2012 at 19:28

Alberto Bonsanto

18.1k10 gold badges67 silver badges93 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Alberto Bonsanto Over a year ago

This is fast not deep thinking solution

Fabien Over a year ago

You will copy useless characters with this solution. And, that is generally slower than using strcpy or memcpy, which are usually optimized by compilers.

Alberto Bonsanto Over a year ago

@Fabien, that's correct that's why I said "fast and not thinking solution"

Ricsie Over a year ago

if i use this i get about 20-30 weird chars like &@-:-/ and so on, it looks like i copy from bad source, but then i tried to print array1[0] it prints: Croatia then i tried to do for (i = 0; i < 30; i++){array2[0][i] = array1[0][i] } then when i print array1[o] i get Croatia and when i print array2[o] i get again these 30 weird characters

Ricsie Over a year ago

It somehow didnt worked for me, but deleted the whole project folder just copied the code to new project and tried the strcpy again and now it worked. Thanks a lot for helping me and so fast help, much appreciated!!

Fabien · Accepted Answer · 2012-11-08 19:26:35Z

1

For the first error : you cannot copy an array into another one. You can just copy salar values (chars, in your case).

If you want to copy a string into another, you indeed have to use the strcpy function (or a close relative, as strncpy. You should give us the full code so that we can see where the problem is with your call to strcpy.

answered Nov 8, 2012 at 19:26

Fabien

13.6k10 gold badges48 silver badges66 bronze badges

3 Comments

Ricsie Over a year ago

When i use strcpy it prints me something like this: !"#$%&'<>*+,-./

Fabien Over a year ago

Did you check that fr is actually valid ? i.e., did you check, while opening it, that everything was OK ? If something went wrong, fris NULL and then anything can happen.

Ricsie Over a year ago

yes i checked if its not NULL also checked array1[0] and printed it it prints: Croatia

Collectives™ on Stack Overflow

Copy Array of strings in C error

2 Answers 2

5 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related